Repository navigation
build(ts): Upgrade to TypeScript 7 with strict compiler checks - #2171
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sentry Evalsjunior-behavioral
Base commit junior-guardian
Base commit junior-integration
Base commit junior-router
Base commit |
joshuarli
approved these changes
Oct 16, 2026
Co-Authored-By: Joshua Li <[email protected]> Co-Authored-By: Joshua Li <[email protected]>
sentry-junior
Bot
force-pushed
the
build/typescript-7-strict
branch
2 times, most recently
from
October 21, 2026 21:25
8d78af5 to
ad58914
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ad58914. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Moves the workspace packages and the example app from TypeScript 6.0.3 to 7.0.2. It also adopts the strict compiler settings from
getsentry/eng-pipesthrough a new roottsconfig.base.json, which every packagetsconfig.jsonnow extends.New checks:
noUncheckedIndexedAccess,noImplicitOverride,noImplicitReturns,noFallthroughCasesInSwitch,noUnusedLocals,noUnusedParameters,noUncheckedSideEffectImports,erasableSyntaxOnly,allowUnreachableCode: false, andallowUnusedLabels: false.Not included yet:
exactOptionalPropertyTypes. eng-pipes enables it, but here it reports about 1,000 errors across hundreds of option and record types. That is a separate migration, so I left it for a follow-up.Source fixes for the new checks. Most are small guards for indexed access that can be
undefined. Other changes:SubscribedReplyReasonis now a const object, becauseerasableSyntaxOnlyrejects both.return undefined.!where the fixture already proves the value exists.Tooling changes. TS 7 does not ship the JS compiler API.
@sentry/juniorstays on tsdown, which now emits types with TS 7.StructuredToolResultEnvelopeis exported because declaration emit has to name it, andsrc/cli/**is added totsconfig.build.jsonso the CLI entries get declarations.junior-memoryandjunior-plugin-apimove from tsup to tsdown. tsup's declaration bundler needs the old API, and unbundledtscoutput fails the attw node16 check because these sources use extensionless imports.junior-dashboardkeeps tsup for its JavaScript (it has a custom esbuild asset plugin). It uses a dts-only tsdown config fordist/index.d.ts.@typescript/typescript6.@typescript/typescript6throughpackageExtensions. Without that it silently cruised 0 modules on TS 7. It now cruises 536 again.packages/docsstays on TS 6 because@astrojs/checkdoes not support TS 7.junior initnow scaffoldstypescript@^7.0.2. The example app tsconfig is unchanged so it stays aligned with the scaffold.via @joshuarli.
--
View Junior Session [Sentry]