Skip to content

ci(release): Bump craft to 3.9.0 and update config - #252

Merged
joshuarli merged 2 commits into
mainfrom
ci/bump-craft-3.9.0
Nov 3, 2026
Merged

joshuarli merged 2 commits into
mainfrom
ci/bump-craft-3.9.0

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This bumps the pinned getsentry/craft action in release.yml and the craft changelog-preview.yml reusable workflow from 2.35.1 (0ff75896, labeled # v2) to 3.9.0 (2e29b081).

Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the action kept going and could still prepare a release and open a getsentry/publish issue while a release-blocker issue was open (seen in getsentry/symbolic). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and it also fails if the blocker lookup errors.

Compatibility with craft 3.x:

  • The workflow's action inputs (version, force) are unchanged in 3.9.0; releases between only added optional inputs.
  • None of the 3.0 breaking changes apply: .craft.yml doesn't set changelog.includePaths/unownedPaths, there's no nuget target, and minVersion is 0.34.1, so craft keeps running scripts/bump-version.sh instead of the new automatic bumping.
  • The 3.9.0 changelog-preview workflow asks for the same permissions this repo already grants (contents: read, pull-requests: write, statuses: write) and has no new required inputs.
  • I ran the craft 3.9.0 binary with prepare 99.0.0 --dry-run --no-push on current main. It ran scripts/bump-version.sh, bumped pyproject.toml, and finished without errors.

There are no open release-blocker issues in this repo right now. Once this lands, any open one stops releases until it's closed or force is set.

Config changes (follow-up commit, so .craft.yml matches craft 3.9.0):

Sets minVersion from 0.34.1 to 3.9.0. Under the old minVersion, craft defaulted to running scripts/bump-version.sh and to the manual versioning policy. At 3.9.0 those defaults become automatic target bumping and auto, so this also adds preReleaseCommand: bash scripts/bump-version.sh and versioning.policy: manual to keep releases working the same way.

I ran craft 3.9.0 prepare 99.0.0 --dry-run --no-push before and after this change on a full clone. Both runs bumped pyproject.toml with no new warnings or errors.

via @BYK.

--

View Session in Sentry

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4091bbf. Configure here.

Comment thread .github/workflows/release.yml Resolved
@sentry-junior sentry-junior Bot changed the title ci(release): Bump getsentry/craft to 3.9.0 ci(release): Bump craft to 3.9.0 and update config Nov 3, 2026
@joshuarli
joshuarli merged commit 307adb0 into main Nov 3, 2026
17 checks passed
@joshuarli
joshuarli deleted the ci/bump-craft-3.9.0 branch November 3, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants