Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #252
Merged
Merged
Conversation
Co-Authored-By: BYK <[email protected]>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4091bbf. Configure here.
Co-Authored-By: BYK <[email protected]>
joshuarli
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This bumps the pinned
getsentry/craftaction inrelease.ymland the craftchangelog-preview.ymlreusable workflow from 2.35.1 (0ff75896, labeled# v2) to 3.9.0 (2e29b081).Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the action kept going and could still prepare a release and open a getsentry/publish issue while a
release-blockerissue was open (seen in getsentry/symbolic). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and it also fails if the blocker lookup errors.Compatibility with craft 3.x:
version,force) are unchanged in 3.9.0; releases between only added optional inputs..craft.ymldoesn't setchangelog.includePaths/unownedPaths, there's no nuget target, andminVersionis 0.34.1, so craft keeps runningscripts/bump-version.shinstead of the new automatic bumping.contents: read,pull-requests: write,statuses: write) and has no new required inputs.prepare 99.0.0 --dry-run --no-pushon currentmain. It ranscripts/bump-version.sh, bumpedpyproject.toml, and finished without errors.There are no open
release-blockerissues in this repo right now. Once this lands, any open one stops releases until it's closed orforceis set.Config changes (follow-up commit, so
.craft.ymlmatches craft 3.9.0):Sets
minVersionfrom 0.34.1 to 3.9.0. Under the old minVersion, craft defaulted to runningscripts/bump-version.shand to themanualversioning policy. At 3.9.0 those defaults become automatic target bumping andauto, so this also addspreReleaseCommand: bash scripts/bump-version.shandversioning.policy: manualto keep releases working the same way.I ran craft 3.9.0
prepare 99.0.0 --dry-run --no-pushbefore and after this change on a full clone. Both runs bumpedpyproject.tomlwith no new warnings or errors.via @BYK.
--
View Session in Sentry