Repository navigation
RefundOrder tool returns clear result for missing payment records - #7
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the
refundOrdertool inapps/storefront/lib/ai/tools.tsto gracefully handle cases where an order has no corresponding payment record. Previously,db.selectPayment(orderId)would throw an error for such orders (e.g., legacy orders predating the payments launch), leading to an unhandled exception being captured by Sentry.Now, the call to
db.selectPayment(orderId)is wrapped in atry/catchblock. IfselectPaymentthrows, therefundOrdertool will return a structured result{ refunded: false, reason: error.message }. This allows the AI to receive a clear tool result and respond gracefully to the user, preventing unhandled exceptions.Fixes DEBUGGING-AGENTS-STOREFRONT-2
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run