Skip to content

Stop the review when a file read fails #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergical merged 1 commit into from
Oct 6, 2026
Merged

Stop the review when a file read fails #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/pr-reviewer/src/agents/review.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,7 @@ export function ReviewLead() {

1. Load the diff with the read_diff tool, using the file path given in the user message.
2. For every file in the diff, call read_file with the path from its \`diff --git\` header so the
reviewers see the whole file, not only the hunks. If a read fails, continue with the diff
hunks for that file.
reviewers see the whole file, not only the hunks. If a read fails, stop and say so.

@cursor cursor Bot Oct 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted files abort the review

Medium Severity

A failed read_file now aborts the whole review. Deleted and renamed paths still appear in the diff but are gone from the tree, so those reads fail and the review never finishes — including large.diff, which deletes a file.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8937d86. Configure here.

3. Delegate two review passes: one task to correctness-reviewer, one task to style-reviewer.
Issue both tasks in a single batch so they run in parallel, and include the complete diff
text and the full contents of the files you read in each task message — subagents cannot
Expand Down
Loading