Repository navigation
Update Memorise pin to v0.10.5 - #1845
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Memorise v0.10.5 is approved, @monarchmaisuriya. The pin update is ready to merge. Your overview, description and interface image are retained; no registry edits or action from you are needed.
Review data
- Policy: main
REVIEW.mdblob3c5e763c9565b93ea33fa48c9aeb83e415c72d67. Reviewed registry head0a7f868dae9a071b0ab89afcef37784d7bc845fd. Read the PR and discussion, original submission #1167, original review #1168, and previous update review #1495. Submitter, original submission author and source repository owner share GitHub account ID 37824914. - Independently fetched and compared exact Git trees from
https://github.com/monarchmaisuriya/memorise.git:42773936adc8fb3ac564faa6f796c591fcab6a01→083995db22d7776c0fc1bc49472d594ad32af8cb. The v0.10.5 tag resolves to the proposed commit. Checked all archive paths/types before confined extraction, without hooks or submodules. Archive SHA-256: old5b20a0d0e7d4972c6ede692054ac4ee73bdd954a693b5c27b9eed560ff7dca89, new434524504c46ca2d62382b56c79472d9627374bc6d9a2bce8df3d8197fb7bac1. - Read every runtime change and its affected migration, storage, proposal, capture, client-card and authenticated MCP paths; read changed test coverage, manifest/package metadata, README changes and the displayed English overview. Both entries and local import targets exist. No translations are supplied. Unchanged worker/provider and dependency implementations were not exhaustively re-audited.
- Preparation remains
npm ci --omit=dev --ignore-scripts; package/lock root declarations agree. All 95 production lock entries have exact versions, npm-registry sources and SHA-512 integrity; none declares installation hooks. Dependency tree, manifest and existing Git subprocess interface are unchanged. No plugin/dependency code was installed, built, imported or executed, and plugin tests were not run. - Folder migration:
server/project-keys.ts:44folds entries with matching inode and nonzero creation time into the first key, retaining aliases and reserving those keys.server/plugin.ts:89runs migration before capture, interop and MCP startup.server/store.ts:222copies validated memories under the retained key, preserves existing destination IDs, then renames originals with.merged;server/proposals.ts:125preserves proposal IDs/dates, skips known suggestions and similarly renames old files. Operations use validated repo keys and fact IDs under the plugin's memory/proposal data folders. A per-file failure is logged; failed old-file renames leave the source for retry. No unrelated file deletion is introduced. server/mcp.ts:335verifies the signed bearer token before canonicalizing its project key; existing agent tokens, UI requests and interop suggestions reach the retained project. Global-write restrictions and loopback binding remain. Migration brings the repaired folder's memories back into the existing prompt/provider data flow described in the overview. No new network destination, credential reader, subprocess, remote-code acquisition or evaluation was introduced.- Chat changes append unique receipt/proposal row IDs and filter suggestions by both source agent and the current pass's pending IDs. Failed automatic saves remain waiting. These are UI-only cards; capture/provider selection and approval rules remain unchanged.
- Retained the author's description and authoritative English overview, plus the existing suitable interface image. Fetched image returned HTTP 200
image/png, SHA-2568f2249316663ee9ffcaa66e6064085a3cf8a3775df56e3adf8d7a4e43a275a12; viewed the sample-memory panel and controls. No redundant registry fallback is needed. - Trusted current-main online validation passed: 463 well-formed records, one matching changed artifact, zero skipped. Trusted registry tests passed 189/189; exact-head Validate CI passed. Registry machinery matches main. No factory-policy conflict or concrete remaining acceptance requirement identified.
- Limits: static artifact review, no independent live Mac restart, migration-failure injection, UI/fork/provider QA or plugin test execution. Author-reported 273 tests, typecheck and live installation are supporting claims, not checks rerun here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Memorise pin from v0.10.1 (
4277393) to v0.10.5 (083995d), ready for artifact review. Submitted by @monarchmaisuriya.-2, which split their memories across two keys. A folder is now recognised by its inode and creation time only, as Contextualise does. Keys already split are repaired at the next start: the later keys become aliases of the first, and their memories and suggestions move to the first key. Old files are renamed aside with.merged, never deleted.Permissions
Unchanged since v0.10.1: same manifest, dependencies, and hooks, and the lockfile changes only in its version number. There is no new network access, and no new processes. The new file writes, renames, and deletes stay inside Memorise's own data folders.
Tested
npm testpasses (273 tests), and typecheck is clean at083995d.v0.10.5on my own Paseo 0.15.0 daemon, where it is running. Forking from earlier replies works in new chats.scripts/validate.tslocally.🤖 Generated with Claude Code