Repository navigation
Review DeepSeek Harness (desktop) - #1842
Merged
Merged
Conversation
1 of 9 tasks
Contributor
There was a problem hiding this comment.
DeepSeek Harness (desktop) is approved, @AksuRedapple. I completed the pinned registry record with your category and attribution and removed the intake file, retaining your description and overview. No action is needed from you; publication follows merge.
Optional next release: mention that debug logs include prompt excerpts, and clarify that DSH_BASE/DSH_MUX overrides send requests to the configured endpoints. This helps users understand where their prompts and authentication go. Overview guidance.
Review data
- Policy: main
REVIEW.mdblob3c5e763c9565b93ea33fa48c9aeb83e415c72d67. Intake head95b994bfb0c9f057b86d6613f05d4fec1e6d8d86; completed reviewed head4505d4e93ab49af949ae90d35a581180539b117a. Read the PR, discussion and linked submission #1841. Submitter and source repository owner share GitHub account ID 307688720. - Artifact: root of
https://github.com/AksuRedapple/dsh-paseo-provider.git, exact main commit resolved during reviewea83d79c7b02c044a01838399e2212c5edd25c62(package 2.0.0). Fetched without hooks/submodules; checked all archive paths/types before confined extraction. Git archive SHA-256ac7fe5c5e14a81d4c85165060d67cdcf19669a9a2f0dcced515b0efb4a0761a9. - Inspected the server entry and all runtime modules, declarations/imports, manifest, package metadata, lockfile, README, English overview, provider SVG and verification/troubleshooting documentation. No custom client interface or translations; this server provider uses Paseo's existing interface and needs no screenshot. The provider SVG is its registration icon, not listing media.
- Preparation is exactly
npm ci --omit=dev --ignore-scripts. The synchronized npm v3 lock fixes the sole production dependency[email protected]to its npm tarball and SHA-512; the other four locked packages are development-only. Independently downloaded and checked the ws tarball against npm metadata and the lock:sha512-oyL6OPYme/CmiFvNuGzeoxCJ4nOrZE2O1FwM9MWM1AsGri6nLXB2pg+lNA8aLeXMSav0J6eIVS1j6vUPzUtK9g==. Inspected its package metadata, imports and client connection/optional acceleration paths; no acquisition lifecycle script or installed transitive production tree. Optional native accelerators are absent from the locked tree. No plugin/dependency code was installed, built, imported, required or run. server/dsh-endpoint.mjsreads only the selected DSH web log and explicit DSH environment settings. Default discovery takes the last launch token/port and exchanges it on loopback with redirects disabled; the resulting cookie is cached in memory. Explicit endpoint overrides skip log discovery and use the supplied cookie.server/dsh-client.tssends JSON RPC requests and that cookie to the resolved HTTP endpoint; snapshots and turns use the resolved WebSocket mux. HTTP authentication failure refreshes discovery once. No independent telemetry destination or credential-store reader was found.server/provider.tsmaps catalog/list/open/prompt/model-selection/interrupt actions to fixed DSH RPC method names. Prompt text and image bytes go to DSH, which owns model-provider transmission and tool execution as the overview discloses. History and tool outputs become Paseo timeline data; displayed shell/file details are not executed by this plugin. Debug logging includes truncated incoming messages and prompt excerpts. No direct subprocess, shell/eval, runtime software installation, file write/delete or DSH-profile modification was found in the runtime. Permission responses are ignored and the capability is not advertised; the overview explicitly says DSH's own preset governs tools.- Persistent follow uses session-scoped stream IDs, sequence baselines, reconnect and gap/truncation notices. Turns have a 120-second stream budget and 60-second pending-tool timeout; cancellation closes the stream and the interrupt action also calls DSH cancel. Closing a session only aborts the local stream and forgets its mapping, rather than deleting DSH history. These protocol/platform behaviors were traced statically, not exercised against a live DSH app.
- Registry edits: add
plugins/aksuredapple/dsh-paseo-provider.jsonwith exact artifact/repository pin, supplied providers category, verified attribution and original submission time; removesubmissions/1841.json. English author overview/description remain authoritative; no redundant registry fallback. Trusted current-main online validation passes: 462 well-formed records, one matching changed artifact, zero skipped. The held intake validation was approved; its intake-only failure is superseded by the completed proposal. - Limits: static review, no independent live provider/UI/platform testing or exhaustive third-party audit. Author CI passed on the artifact commit; documented macOS/live DSH checks are author evidence, not rerun here. DSH private-protocol compatibility, Windows/Linux behavior and reconnect/close behavior in a live app remain unverified. No concrete malicious or seriously unsafe behavior, remaining author requirement or policy/validator incompatibility identified. Exact-head registry CI and head are checked before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1841. Submitted by @AksuRedapple.
Ready for artifact review. The reviewer will resolve the submitted source and complete the registry listing.
Submission:
submissions/1841.json.Git references are optional. Use a supplied reference; otherwise resolve main during review. Git updates are submitted manually.