Repository navigation
Review Paseo Approvals - #1227
Merged
Merged
Conversation
Closed
3 of 9 tasks
|
Author context, screenshots and scoped verification are in the submission comment. The submission correctly pins b8df881. The Validate run currently reports |
Contributor
There was a problem hiding this comment.
Paseo Approvals is approved, @delirious6423. I completed the pinned registry record and attribution, retained your overview and both interface images, and removed the intake file. Nothing else is needed from you for this submission.
Review data
- Reviewed registry head:
9f1786717d91484961b6ae104b55a0e7744dad34. Main:9998ae63a7eb39440cc2b4fd9ea051801454273b; REVIEW.md blob:8da1286fd8870c87ff53767e8644858627b7371f. Read the complete PR and linked submission #1226, including the author's verification scope and validation question. The updated head's Validate run passed: https://github.com/getpaseo/plugins/actions/runs/40335936621. - Artifact: Git
https://github.com/delirious6423/paseo-approvals.git, root directory, exact requested commitb8df881b49c81fb56fb021f6ffddfcc6a77eab29. Confirmed it is a commit on the declared remote; no tag asserted. Tree archive SHA-256:8135dbcc3efbe42210ed7b308cbca124f8e74f88b9982a476eff6526a3f59044. Checked every archive path/type before extraction, regular files/directories only; no hooks or submodules executed. Submitter matches repository owner and package repository identity. Legacy manifest IDstandardnotes-approvalsis explicitly documented. - Read every production module: server/client entrypoints, connector subprocess bridge and hub, strict RPC/settings/result contracts, native Standard Notes protocol adapter, text/error normalization, review selection/gating, screen, controls and settings. Also inspected manifest/package metadata, README, overview, configuration/protocol/security documentation and the optional synthetic connector. Both declared PNGs were visually inspected and show the actual review interface with synthetic data. English name, description and overview are supplied; no translations declared.
- No manifest build/preparation command, runtime package dependencies, install lifecycle script or runtime downloader. External imports use host-provided SDK, React, React Native, React Query and zod; package dependencies are development-only. The development lock is not installed by this plugin. No plugin, test, build or dependency code was run.
- Opening/reloading a configured app invokes its fixed executable/arguments from host settings via
execFilewithshell:false; request JSON goes through stdin (server/bridge.ts:18-47,64-79). Connectors inherit the daemon environment and user privileges; optional Standard Notes overrides only the documented account/server/state variables. Paired trusted clients can edit executable settings. RPC inputs do not supply commands or arguments. Processes have bounded input/output, a 30-second timeout and SIGTERM/SIGKILL cleanup. This intentional local execution and trust boundary are disclosed. - Decisions re-read the preview, bind its immutable content/target/expiry/upstream digest and connector configuration in SHA-256, reject changed or expired inputs, re-read settings, then forward the upstream digest (
server/hub.ts:43-78). The external app must atomically enforce its own decision and commit; the plugin does not apply changes or establish human authentication. Its overview states these limits. - Preview text is literal React Native Text, bounded to 256 KiB after normalization; portable hidden/control characters become visible markers. Review resets with app/host/settings/request changes. Approval requires confirmation and reaching the end; decision failures are not retried automatically. Previews reach connected clients through Paseo transport, potentially its relay. No direct network listener, telemetry, provider forwarding, keychain access, arbitrary filesystem mutation or software installation was found in production source. Configured connectors can access their own application services and files as disclosed.
- Registry edits: added
plugins/delirious6423/approvals.jsonwith exact pin, requested categories, human attribution and submission/review timestamps; removedsubmissions/1226.json. Author description, OVERVIEW.md and media are used without redundant overrides. Trusted current-main online validation passed for the completed record; Validate CI passed on this exact head. - Limits: static review, no live application, connector, native/mobile, relay or service tests. External user-supplied connectors and the separately installed Standard Notes bridge are not bundled or certified by this review. Author-reported test results are supporting evidence, not tests executed here. No serious safety hold or remaining author requirement identified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1226. Submitted by @delirious6423.
Ready for artifact review. The reviewer will resolve the submitted source and complete the registry listing.
Submission:
submissions/1226.json.Git references are optional. Use a supplied reference; otherwise resolve main during review. Git updates are submitted manually.