Repository navigation
Bump fxbing/workboard to 0.3.4 - #1222
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Workboard 0.3.4 is approved for publication, @fxbing. I refreshed the review timestamp and retained your English and Chinese pages and existing media. Nothing further is needed from you.
For the next release, explain the empty-workspace archive countdown in the overview: it starts from a complete empty inventory and resets after disconnection or an Agent change. This helps users understand postponed archive dates.
Review data
- Reviewed registry head:
0d9d93c3a45bc3d65d5aa165601769352e0b29db. Main REVIEW.md blob:8da1286fd8870c87ff53767e8644858627b7371f. - Independently downloaded and compared npm
paseo-workboard0.3.3 and 0.3.4, matched both records and npm version/tarball/SHA-512 metadata, and checked archive paths/types before extraction. Each contains 51 files. New artifact:https://registry.npmjs.org/paseo-workboard/-/paseo-workboard-0.3.4.tgz, integritysha512-shvB6v3+naL/ttjnPKvAPFcArxDY8rMQMjwPnModkO+0EqMwqOuPAUbLjais2KKprbO8Q3MefMLI0MyyBGEWHw==. Existing submittedBy, package author and repository attribution agree. No npm provenance reported or source-match gate imposed. No linked registry submission issue found in this bump or its history. - Inspected the full independent delta in client strings, index.server.ts, server/host.ts, server/test-clock.ts and server/workboard.ts, package/manifest metadata, both overviews and translation metadata, runtime imports, and the affected inventory, conversation verification and archive paths. No runtime dependencies or preparation commands; imports use host libraries and local files. Package scripts are author development/publication checks, with no installation lifecycle hooks; none were run.
server/workboard.ts:308-333,700-724records an in-process conservative bound only after successful complete inventory with no agents, no remembered children and no unresolved conversation reason. Agent events and disconnects clear that bound; inventory failures clear it, and events during an inventory prevent admitting a new bound. Persisted observations are rejected when the admitted empty bound changes. Unresolved child history/enumeration still keeps the archive gate unknown. The activity display ignores an idle lastError-only agent only when a healthy agent has a newer user message; explicit error attention is retained. Archive safety continues to inspect actual agents rather than that display summary.- Automatic archive remains off by default, separately enabled for Done/Canceled, and limited to configured delays.
server/workboard.ts:1814-2033rechecks conversation/children and current inventory, rejects active agents/workspaces, checks terminals/scripts and Git safety, persists intent, then rechecks membership/labels/agent fingerprints/change epoch and safety before calling native archive. Native archive can remove managed worktrees, as both overviews disclose. No direct filesystem deletion is added. server/test-clock.ts:37-78reads the optional offset file only after an explicit test offset, an absolute Paseo home physically under a temporary directory, and the exact integration marker; ordinary hosts retain the real clock. No new runtime download or external data destination. Existing host IPC uses the authenticated Paseo session; existing Git safety uses execFile argument arrays and checks the configured remote with ls-remote.- The supplied English/Chinese pages and descriptions remain accurate; packaged visual media is unchanged and the board screenshot was visually inspected. Only registry edit is reviewedAt. Trusted current-main online validation passes for one changed artifact; the same unchanged registry scripts passed all 172 tests during this execution. Exact-head GitHub validation passes.
- Static artifact inspection only: no plugin or dependency installed, built, imported or executed, and no live archive/provider/UI test. Timing races and compatibility with every supported host were not exercised. The overview suggestion is optional next-release advice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fxbing/workboard: 0.3.3 → 0.3.4
@fxbing, this update is ready for review. The published version stays unchanged until approval.
Artifact and validation details
Package:
paseo-workboard.{ "previous": { "kind": "npm", "package": "paseo-workboard", "version": "0.3.3", "resolved": "https://registry.npmjs.org/paseo-workboard/-/paseo-workboard-0.3.3.tgz", "integrity": "sha512-SUkTIEuxt/GXsnVDtcE6D3x82bwi2udeZYi9sx7VysqZUy/n8Ar5llF6oU5awnnqbSbeChGsTDA7BmIQvsxyPA==" }, "proposed": { "kind": "npm", "package": "paseo-workboard", "version": "0.3.4", "resolved": "https://registry.npmjs.org/paseo-workboard/-/paseo-workboard-0.3.4.tgz", "integrity": "sha512-shvB6v3+naL/ttjnPKvAPFcArxDY8rMQMjwPnModkO+0EqMwqOuPAUbLjais2KKprbO8Q3MefMLI0MyyBGEWHw==" } }Inline validation passed: tests and artifact checks. Run
node scripts/validate.ts --online --changedon the completed listing before merging. The default GITHUB_TOKEN does not trigger the PR validation workflow.Artifact diff