feat(args): add the wrap-cols argument - #366
Merged
Merged
Conversation
Hinode v3.23.0 added `wrap-cols` to the table shortcode, folding a record into column groups on small devices instead of moving only its last column. It was defined inline in hinode's own structure file, which is enough for one consumer. mod-blocks' list component now forwards the same argument, and a bookshop blueprint carries no inline types - every key resolves against this file through the snake_case to kebab-case lookup. Without a definition here, `wrap_cols` fails validation with "schema: missing type for 'list.wrap_cols'" and the build errors out, the same way `filter-responsive` did. The type matches hinode's inline declaration, so the two merge rather than conflict. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Collaborator
Author
|
🎉 This PR is included in version 6.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
wrap-colsto the global argument definitions.Why
gethinode/hinode#2138 (released in v3.23.0) added
wrap-colsto the table shortcode, folding a record into column groups on small devices rather than moving only its last column. It was declared inline in hinode'sdata/structures/table.yml, which is enough while there is one consumer.mod-blocks'
listcomponent now forwards it. A bookshop blueprint carries no inline types — every key resolves against this file via the snake_case → kebab-case lookup inArgsSchema.html— so without a definition here the build fails hard:Exactly the shape of #365 for
filter-responsive.Compatibility
The type matches hinode's inline declaration (
string, optional), soArgsSchema.htmltakes the plain merge path rather than the redeclared-type path. Purely additive: a new optional argument, so no existing component changes behaviour.Testing
pnpm test— golden check passed (14 groups), no snapshot movement.HUGO_MODULE_REPLACEMENTS) plus hinode v3.23.0: the list component's table emitsdata-table-wrap-cols=1,2,1. Without this branch the same build fails with the error above.Blocks
gethinode/mod-blocks — the
listforward cannot merge until this ships.