fix(table): style the responsive filter toggle as a button - #2139
Merged
Conversation
Below the breakpoint `filter-responsive` replaces a row of outline buttons with a dropdown, but the toggle inherited the nav's borderless treatment: no border, no background, no padding. Where a group of buttons had been there was a bare word in body text, 32x24 with nothing to indicate it could be opened. It worked, and read as if it did not. Give panel-dropdown a `toggleClass` for the toggle's appearance, defaulting to the nav's borderless treatment so a section menu is unchanged, and have the table pass the button classes it stands in for. The toggle goes from 32x24 to 57x38 with a border and padding. `dropdown-toggle` is emitted by the partial rather than left to the caller: it draws the caret and Bootstrap keys its JavaScript off it, so a caller that omitted it would get a control that neither indicates nor opens. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
markdumay
enabled auto-merge
August 24, 2026 05:21
Collaborator
Author
|
🎉 This PR is included in version 3.23.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Styles the
filter-responsivedropdown toggle as a button, so it reads as the control it replaces.The problem
Below the breakpoint the filter's row of
btn btn-outline-primarybuttons is replaced by a dropdown — but the toggle inheritedpanel-dropdown's nav treatment:link-body-emphasis border-0 bg-transparent p-0.That is right for a nav's section menu, where the toggle sits among prose. On a filter it renders the active category as a bare word in body text, 32×24px, exactly where a row of buttons used to be. Nothing about it indicates a control, or that it opens. Reported as "I can't use the dropdown selector" — the mechanism worked; the affordance did not.
The change
panel-dropdowntakes atoggleClassfor the toggle's appearance, defaulting to today's borderless treatment so nav output is unchanged. The table passes the button classes it stands in for.dropdown-toggleis now emitted by the partial rather than left to the caller — it draws the caret and Bootstrap keys its dropdown JavaScript off it, so a caller that omitted it would get a control that neither indicates nor opens. The only effect on existing output is class order.link-body-emphasis dropdown-toggle border-0 bg-transparent p-0dropdown-toggle btn btn-outline-primary0/ none6px 12px/1pxTesting
Built and driven at 390px against the example site:
.dropdown-item, so it is genuinely painted and clickable.id-demostill emitslink-body-emphasis border-0 bg-transparent p-0, the same classes as before, reordered only. Section menus are visually unchanged.pnpm lintandpnpm test:templatespass.Note
This does not change alignment. A filter row whose block sets
justify: centerstill centres the dropdown, because the section centres a shrink-wrapped row — that is a site-level layout choice rather than something the partial should override, and infusal.io handles it locally.