Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The shared composer treated pasted thread URLs as ordinary text instead of resolving them into existing thread mentions.
What changed
How you verified
08261de44e, including builds, typechecks, lint, bundle budgets, and Linux/Windows tests.08261de44e: security and performance clear; architecture and correctness share one P2 follow-up below. No P0/P1.The 19 lifecycle, 14 parser, and 156 shared-composer tests pass remotely. Clipboard payloads use browser ClipboardEvents; native clipboard shortcut dispatch was unavailable. Real keyboard-handler regression tests cover Cmd/Ctrl+Shift+V. User QA remains pending.
P2 follow-up: mixed HTML pasted immediately after an existing word can shift clipboard protection indexes and convert a code URL. Preserve paste-relative occurrence identity or skip when contextual filtering changes correspondence. See paste filtering.
Screenshots use identical fixture data and route at 2× density. Before:
75308f4076; after:08261de44e.BB-Thread-ID: thr_xeaa8vnrt2