Improve handle resolution by racing DNS vs. /.well-known - #4
Merged
Conversation
germ-mark
reviewed
Dec 12, 2025
| } | ||
|
|
||
| public protocol ResponseProviding { | ||
| public protocol ResponseProviding: Sendable { |
Collaborator
There was a problem hiding this comment.
In the parent, Matt has a conditional conformance of ATResolve sendable if ResponseProviding is sendable.
This requires ResponseProviding to always be sendable. Which to make the task groups work might be necessary.
But you know who might have a better option on this...
germ-mark
reviewed
Dec 12, 2025
germ-mark
reviewed
Dec 12, 2025
This reverts commit 9c360c7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging in Mark's work on DNS/well-known racing (improvement to my earlier PR)
Incorporating the /.well-known approach means that we can use it for Bluesky handle resolution, so I removed the special casing for Bluesky handles.