Replace public distribution with winner claim lifecycle - #447
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
this PR closes #405
test(giveaway): add two edge-case tests for claim lifecycle
What changed
test.rsAdded two tests to cover gaps in the existing claim lifecycle suite:
test_pick_winner_emits_winner_selected_eventVerifies that
pick_winneremits aGiveawayWinnerSelectedevent with the correct topics (giveaway,winner, winner address) and that theprize_amountin the data vec equals the full gross share before any fee deduction.test_partial_claim_creator_receives_exact_unclaimed_gross_shares3-winner giveaway where only winner-0 claims before the deadline. After the window expires, asserts the creator recovers exactly the two unclaimed gross shares with no fee deduction on recovery, and the contract retains only the fee from the single successful claim.
Test results
Checklist
npx prisma generateafter schema changesnpx prisma migrate devornpx prisma migrate deployas appropriatePost-Merge Steps for Maintainers
If this PR includes changes to the Prisma schema:
Run the following command to apply the migration to your database:
or, for local development:
Ensure your CI pipeline runs the migration before tests (add this step if missing):
Make sure the database user in CI has permission to run migrations.
If you have any questions, please comment on this PR.