Skip to content

fix: stabilize premium e2e settings isolation and HEIC waits - #74

Merged
bfintal merged 1 commit into
developfrom
fix/e2e-heic-ci
Aug 12, 2026
Merged

fix: stabilize premium e2e settings isolation and HEIC waits#74
bfintal merged 1 commit into
developfrom
fix/e2e-heic-ci

Conversation

@bfintal

@bfintal bfintal commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restore smart_optimization (and related defaults) after premium specs that disable it, and reset defaults in settings-unlocked so it no longer fails from option pollution.
  • Force upload MIME types in uploadSampleViaMediaNew, improve MIME mismatch diagnostics, and raise the HEIC → WebP wait to 180s for cold heic2any WASM loads on CI.

Test plan

  • Premium CI e2e: settings-unlocked passes after earlier specs that set smart_optimization: 0
  • Premium CI e2e: HEIC → WebP upload passes (or fails with a clearer unexpected MIME message)
  • Spot-check that LQIP / optimize-all / optimization-toggle / stealth still pass

Summary by CodeRabbit

  • Tests
    • Improved media upload validation by checking filenames, MIME types, and file contents more precisely.
    • Increased reliability of premium feature tests by consistently restoring optimization and related settings between test runs.
    • Added clearer setup for premium settings scenarios.
    • Allowed additional time for HEIC conversion tests to complete successfully.
  • Bug Fixes
    • Reduced test interference caused by settings persisting between scenarios.

Restore smart_optimization after specs that disable it, reset defaults in settings-unlocked, and give HEIC uploads more time for the WASM converter on CI.
@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@bfintal
bfintal merged commit d8ffe37 into develop Aug 12, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b96300e-0fb4-4010-aca8-470affc27fe3

📥 Commits

Reviewing files that changed from the base of the PR and between 6023f1b and f14da50.

📒 Files selected for processing (7)
  • e2e/test-utils/media.ts
  • e2e/tests/premium/lqip.spec.ts
  • e2e/tests/premium/optimization-toggle.spec.ts
  • e2e/tests/premium/optimize-all.spec.ts
  • e2e/tests/premium/settings-unlocked.spec.ts
  • e2e/tests/premium/stealth.spec.ts
  • e2e/tests/premium/svg-heic.spec.ts

📝 Walkthrough

Walkthrough

Media test helpers now provide explicit MIME mismatch results and file payloads. Premium tests restore smart_optimization and related options between tests. HEIC upload tests allow 180 seconds for worker initialization.

Changes

Media and premium test reliability

Layer / File(s) Summary
Media helper assertions and uploads
e2e/test-utils/media.ts
MIME polling now matches expected strings or regular expressions and reports explicit mismatch values. File-picker uploads now pass a filename, MIME type, and buffered contents.
Premium option reset and HEIC timing
e2e/tests/premium/*.spec.ts
Premium tests restore smart_optimization and related defaults. The settings test applies defaults before each test. The HEIC upload uses a 180-second timeout.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • gambitph/Cimo#68: Updates the same media MIME assertion and file-picker upload helpers.
  • gambitph/Cimo#69: Modifies related media helpers and premium settings reset flows.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-heic-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🤖 Pull request artifacts

file commit
pr74-cimo-74-merge.zip f14da50

github-actions Bot added a commit that referenced this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant