ENH: update to Volume.random() and Vertex.random() - #716
Open
marklescroart wants to merge 2 commits into
Open
Conversation
… random) noise that looks more like brain data.
Contributor
|
Thanks for making a new PR! I'll push some changes to make it work, if that's ok. |
Contributor
Author
|
Sure, if you can fix quickly please do, I see now that I goofed up side of random matrix, passed my local test bc I was using other data (not S1) that was uniform in all dimensions.
… On Aug 24, 2026, at 4:07 PM, Aditya Vaidya ***@***.***> wrote:
kroq-gar78
left a comment
(gallantlab/pycortex#716)
<#716 (comment)>
Thanks for making a new PR! I'll push some changes to make it work, if that's ok.
—
Reply to this email directly, view it on GitHub <#716?email_source=notifications&email_token=ABJ6LQ6MOA3WN2RO6FKYWWL5LTDERA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBQGI3TAMBXGMZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5402700732>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ6LQ2LFPROKUPJ5S4I3XL5LTDERAVCNFSNUABEKJSXA33TNF2G64TZHMYTENBXGI3TAOJ3JFZXG5LFHM2TENBQGE4TKNJUHCQXMAQ>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/ABJ6LQZ4TSQGO5BOPWW5VZD5LTDERA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBQGI3TAMBXGMZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/ABJ6LQYP5C6UXBA6DC3I4X35LTDERA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBQGI3TAMBXGMZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.
|
VertexData.random crashed on random_type='uniform' and swallowed invalid random_type values instead of raising. _low_freq_noise returned axis-swapped, DC-dominated (near-flat) data instead of the documented mean-0/s.d.-1 blobby noise. Also promotes falloff_exponent/smooth_factor from **kwargs to named parameters, and adds tests.
kroq-gar78
force-pushed
the
new_low_freq_noise_attempt2
branch
from
August 26, 2026 09:33
03ba8b6 to
6c3d1f2
Compare
Contributor
|
I fixed & tidied things up. I did change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make Volume.random() and Vertex.random() yield blobby (but still random) noise. This changes default behavior (to generate low frequency noise, which looks nicer and more like real data) but preserves old behavior if you change a keyword argument. Default can be reset, but part of the intent here is to change how demo data looks in the gallery (this setting should make for nicer looking plots for some gallery demos).