new alignment text (removed mayavi completely) - #702
Draft
evi-hendrikx wants to merge 2 commits into
Draft
Conversation
evi-hendrikx
marked this pull request as draft
August 21, 2026 20:23
Contributor
|
Is it also worth removing |
Contributor
|
I did delete mayavi_aligner.py in a branch off of Evi’s fork, I thought we would be merging the branches from Evi’s fork onto main in her fork before merging that into main pycortex, I haven’t followed what’s been going on with the PRs from Nilay and others.
… On Aug 24, 2026, at 12:52 AM, Aditya Vaidya ***@***.***> wrote:
kroq-gar78
left a comment
(gallantlab/pycortex#702)
<#702 (comment)>
Is it also worth removing mayavi_aligner.py <https://github.com/gallantlab/pycortex/blob/main/cortex/mayavi_aligner.py> in this PR?
—
Reply to this email directly, view it on GitHub <#702?email_source=notifications&email_token=ABJ6LQ3RVOZYZQBSCGUNONL5LPX4HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZZGIZDINJRGAY2M4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5392245101>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ6LQ65KKD6N4XUZ4SM5SL5LPX4HAVCNFSNUABEKJSXA33TNF2G64TZHMYTENBXGI3TAOJ3JFZXG5LFHM2TEMJXHA3TCNZXGSQXMAQ>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/ABJ6LQ5FVE6QM56T3W5IJI35LPX4HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZZGIZDINJRGAY2M4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/ABJ6LQ5OJJVYZP7L67QBIM35LPX4HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZZGIZDINJRGAY2M4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because your review was requested.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed mayavi completely
Most of the text is close to what it was, just rephrased