Skip to content

Relabel node/edge_ids when node_id start at 0 (crashes motile_tracker) - #272

Merged
cmalinmayor merged 7 commits into
mainfrom
node-id-start-0
Aug 19, 2026
Merged

Relabel node/edge_ids when node_id start at 0 (crashes motile_tracker)#272
cmalinmayor merged 7 commits into
mainfrom
node-id-start-0

Conversation

@TeunHuijben

@TeunHuijben TeunHuijben commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Closes #248

motile_tracker has the problem that the segmentation looks weird when the graph/geff has node_ids starting at 0

This PR add a funtracks function that, upon graph building, relabels the node_ids (and accompanying edge_ids) to start at 1 (all +1)

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.84%. Comparing base (c30396a) to head (3dd528d).

Files with missing lines Patch % Lines
src/funtracks/import_export/_tracks_builder.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   93.92%   93.84%   -0.09%     
==========================================
  Files          59       59              
  Lines        3326     3345      +19     
==========================================
+ Hits         3124     3139      +15     
- Misses        202      206       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TeunHuijben
TeunHuijben marked this pull request as ready for review August 12, 2026 16:43
@TeunHuijben TeunHuijben added 🐛 bug Something isn't working ready for initial review PR ready for first review labels Aug 12, 2026

@cmalinmayor cmalinmayor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅 👍

@cmalinmayor
cmalinmayor merged commit ec1d325 into main Aug 19, 2026
28 of 30 checks passed
@cmalinmayor
cmalinmayor deleted the node-id-start-0 branch August 19, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working ready for initial review PR ready for first review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation ugly when node_ids start at 0

3 participants