Skip to content

SQL - #270

Open
TeunHuijben wants to merge 11 commits into
mainfrom
sql
Open

SQL#270
TeunHuijben wants to merge 11 commits into
mainfrom
sql

Conversation

@TeunHuijben

@TeunHuijben TeunHuijben commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Apart from a long list of tracksdata changes that were necessary, because it secretly handled the SQL backend differently from the in memory backends, on the funtracks side, we only need a few changes:

  • t node attribute is not mutable, so remove from revive_attrs in DeleteNode
  • Tracks.add_feature acts on graph_full
  • give the td_utils the option to pick a backend
  • a temporary tracksdata pin to the graph-views branch, until it gets merged + released

Question, @cmalinmayor, the SQL backend is for sure slower than the in-memory backend, so the benchmarks (that compare to main), will show deprecation. We can either revert the backends to rx or accept the regression. The question is also whether we want SQL to be the default backend, or only when using large graphs. We might have to do our benchmark on both backends separately

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.84%. Comparing base (fa55023) to head (85f947c).

Files with missing lines Patch % Lines
src/funtracks/utils/tracksdata_utils.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   93.92%   93.84%   -0.09%     
==========================================
  Files          59       59              
  Lines        3358     3363       +5     
==========================================
+ Hits         3154     3156       +2     
- Misses        204      207       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TeunHuijben
TeunHuijben marked this pull request as ready for review August 10, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants