SQL - #270
Open
TeunHuijben wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 93.92% 93.84% -0.09%
==========================================
Files 59 59
Lines 3358 3363 +5
==========================================
+ Hits 3154 3156 +2
- Misses 204 207 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TeunHuijben
marked this pull request as ready for review
August 10, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from a long list of tracksdata changes that were necessary, because it secretly handled the SQL backend differently from the in memory backends, on the funtracks side, we only need a few changes:
tnode attribute is not mutable, so remove fromrevive_attrsinDeleteNodeTracks.add_featureacts ongraph_fulltd_utilsthe option to pick a backendgraph-viewsbranch, until it gets merged + releasedQuestion, @cmalinmayor, the SQL backend is for sure slower than the in-memory backend, so the benchmarks (that compare to main), will show deprecation. We can either revert the backends to rx or accept the regression. The question is also whether we want SQL to be the default backend, or only when using large graphs. We might have to do our benchmark on both backends separately