Repository navigation
Conversation
Artifactory curation blocks websocket-driver 0.7.x, which [email protected] (via webpack-dev-server 4 and 5) requires. WDS 6 uses only ws. - https -> server; onBefore/AfterSetupMiddleware -> setupMiddlewares, keeping WDS host checks ahead of src/setupProxy.js - give setupProxy.js its own Express 4 app: WDS 6's Express 5 router rejects snow's app.post('*') and the dev server never starts - map prepareProxy's onProxyReq/onError to http-proxy-middleware v4 `on` - exclude .cjs from the asset fallback; the WDS 6 HMR client imports .cjs - report dev server start errors; use stopCallback (close() was removed) Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
sockjs,faye-websocket,websocket-driverandwebsocket-extensionsfrom@fs/react-scripts' dependency tree by upgradingwebpack-dev-serverfrom 4 to 6. Apps can then drop the"websocket-driver": "^0.8.0"override they added when Artifactory started blockingwebsocket-driver0.7.x.Some apps must keep the override. Anything else that pulls in WDS 4 or 5 still brings
sockjsback. frontier-app-react is one:@storybook/preset-create-react-appdepends on upstream[email protected]. Check withnpm ls sockjsbefore removing it.Config changes required by WDS 5 and 6
https→server, andonBefore/AfterSetupMiddleware→setupMiddlewares. WDS's host checks still run beforesrc/setupProxy.js, as in WDS 4.setupProxy.jsstill gets Express 4. WDS 6 runs on Express 5, which rejects routes like snow'sapp.post('*'). Without this, every snow app's dev server fails to start.setupProxy.jsnow gets its own Express 4 app, mounted inside the dev server's. Addsexpress@^4.22.0.package.jsonproxyhandlers move underon. http-proxy-middleware v4 silently ignores the oldonProxyReq/onErrorkeys..cjsexcluded from the asset loader. WDS 6's hot reload client imports.cjsfiles, which otherwise compile as asset URLs and fail.npm startreports startup failures and exits, instead of hanging silently. Ctrl+C usesstopCallback(close()was removed).webpackrange raised to^5.101.0(WDS 6 peer). Node>=24already satisfies WDS 6.Version 8.18.0. The lockfile only adds and removes WDS's own dependencies; no existing package changes version.
Verified against frontier-app-react
Packed this branch, installed it in a frontier-app-react worktree, and removed the
websocket-driveroverride:npm startcompiles, and snow serves the app on :5006.npm run buildpasses.npm cithrough Artifactory: a minimal app depending only on@fs/react-scriptsinstalls with no 403s and nosockjs. frontier-app-react still 403s on[email protected]because of the storybook preset above.Not tested:
HTTPS=trueand thepackage.jsonproxyfield. frontier-app-react uses neither.🤖 Generated with Claude Code