Repository navigation
feat(plugins): coordinate definition delete with the plugin lifecycle - #105
Merged
Merged
Conversation
Formatting-only change (mdformat --wrap 100) so the following behavior change carries a content-only docs diff.
DELETE /jobs/definitions/{id} now runs DynamicJobLoaderService.deleteJob
under the per-definition lifecycle lock:
- refuse with 409 when the definition has execution history (force does
not bypass it; disable the definition instead)
- unload first, refusing with 409 on running executions unless force=true
- delete parameter templates and the definition in one transaction
- delete the JAR only after commit; a failure leaves a logged orphan JAR
named in the audit instead of failing the request
- audit JOB_DELETED SUCCESS only after completion, FAILURE otherwise
- unknown ids return 404 through the global error handler
Closes #94
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fronzec
changed the title
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style(docs): apply mdformat to plugin lifecycle docs
Formatting-only change (mdformat --wrap 100) so the following behavior
change carries a content-only docs diff.
feat(plugins): coordinate definition delete with the plugin lifecycle
DELETE /jobs/definitions/{id} now runs DynamicJobLoaderService.deleteJob
under the per-definition lifecycle lock:
not bypass it; disable the definition instead)
named in the audit instead of failing the request
Closes #94