fix(theme): stop section pages stranding prose beside full-width blocks - #190
Merged
Merged
Conversation
As _index.md the page used the section-landing layout: a 1344px shell where paragraphs are capped at 66ch but code blocks, the alert and the table run full width, so the prose looked hard-wrapped against a wide empty margin. As a leaf page (index.md, same /nix/ URL, like /bug/) it gets the is-prose column that headings, text and code share. Claude-Session: https://claude.ai/code/session_016xwEnj4eizFJUpd1bPwPQa
Section pages used a 1344px shell where paragraphs are capped at 66ch but code blocks, tables, tabs and alerts run the full width, so the text looked hard-wrapped. A section with no child pages (try, uninstall, donate/thanks, ghostkey/success) now renders in the is-prose article column; one with a card grid (quickstart, build, about, ...) caps the intro as a whole, so its blocks share the text measure while the grid below stays wide. Also make fenced code blocks break out of the prose column as the CSS already intended: Hugo wraps them in div.highlight, so the '> pre' selector never matched one. Claude-Session: https://claude.ai/code/session_016xwEnj4eizFJUpd1bPwPQa
sanity
changed the title
It rendered an empty div whose top margin left a gap at the foot of what is now an article-width page (review finding on #190). Claude-Session: https://claude.ai/code/session_016xwEnj4eizFJUpd1bPwPQa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On https://freenet.org/nix/ (and /quickstart/, /try/, /uninstall/, /build/) the body text looks as if every line were hand-broken. Section pages (
_index.md) render inlist.html's wideis-section-pageshell (1344px). The reading-measure rule caps paragraphs at 66ch there, while code blocks, tables, tabs and alerts run the full width, so the prose sits in a narrow strip beside them.base.cssitself calls this shape one that "reads as a broken layout".Fix
/nix/is an article, so it is now a leaf page.nix/_index.mdbecomesnix/index.md, with the same/nix/URL and the same pattern as/bug/.list.html). The wide shell exists for the child-page card grid; without one it only strands the text. This affects/try/,/uninstall/,/donate/thanks/and/ghostkey/success/.base.css), so code blocks, tabs and alerts share the text measure while the grid below keeps the full width. This affects/quickstart/,/build/,/about/, the manual sections and/resources/..content > pre, but Hugo wraps every highlighted fence indiv.highlight, so it never applied to one. Long commands (e.g. on/uninstall/) were clipped and scrolled instead.Testing
Built with Hugo and screenshotted at 1400px
/nix/,/quickstart/,/try/,/uninstall/,/build/,/donate/thanks/and/about/(the unchanged-grid control), plus/nix/at 420px. Every page reads as one column. Code blocks break out symmetrically on desktop and scroll inside the column on mobile. Card grids are unchanged. The quickstart link to/nix/still resolves.Review note: as a leaf page,
/nix/no longer emits a section RSS feed at/nix/index.xml. Nothing links to it.[AI-assisted - Claude]
https://claude.ai/code/session_016xwEnj4eizFJUpd1bPwPQa