Fix JPEG scaled decoding parity for 0.11.2 - #121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JPEG reduced-resolution decoding could differ from libjpeg-turbo because components used the same IDCT size, chroma was smoothed at unsupported scales or widths, and progressive/12-bit paths decimated full-resolution pixels. Apply per-component reduced IDCTs and the matching upsampling rules across the CPU and Metal paths for the planned 0.11.2 release.
Also fix 12-bit region slice panics, Metal region chroma context at MCU boundaries, CUDA CPU-backed surface dimensions, and the 12-bit scratch budget for live output rows. A 208-image libjpeg-turbo 3.1.4.1 golden matrix covers full images, regions, scale factors, restart markers, progressive images, supported 12-bit layouts, and tall narrow images. Existing unsupported 12-bit layouts still return
NotImplemented; narrow subsampled images reject explicit device requests and use CPU decoding under automatic routing.Validation:
MemoryCapExceededbefore the budget fix and now match libjpeg-turbo, including region reads.