fix: SMTP 설정 누락 시 서버 기동 차단 - #108
Merged
Merged
Conversation
SMTP Provider 활성화 시 host를 필수로 확인하고 인증 사용 시 username과 password 누락을 거부합니다. 정상 설정과 빈 host·인증정보 누락 테스트를 추가했습니다.
hywznn
marked this pull request as ready for review
August 7, 2026 06:10
chaeliki
approved these changes
Aug 7, 2026
krestar
approved these changes
Aug 7, 2026
krestar
left a comment
Contributor
There was a problem hiding this comment.
SMTP 활성화 시 필수 설정값을 기동 단계에서 검증하도록 잘 보완된 것 같습니다.
host 및 인증정보 누락 케이스 테스트도 확인했습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
왜 필요한가요?
PR #106의 후속 수정입니다. SMTP Provider를 선택했는데 연결 설정이 비어 있으면 서버는 정상 기동하고, 비밀번호 재설정 요청도 202를 반환하지만 실제 메일은 발송되지 않았습니다. 데모 시작 전에 설정 오류를 바로 발견할 수 있도록 기동 단계에서 차단합니다.
Refs #55
Refs #106
무엇이 바뀌나요?
검증
병합 전 확인