fix: SignupPage에 서버 필수 agreements 필드 추가 - #280
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
SignupRequest.agreements가@NotNull필수 필드로 바뀌었는데 client는 여전히 안 보내고 있어서, 지금 상태로는 실제 회원가입이 전부 400으로 실패하는 활성 버그였음agreements없이 요청 → 400INVALID_REQUEST/ 포함 → 201 성공SignupPage.tsx가 이미 들고 있던termsAgreed/privacyAgreed/marketingOptIn체크박스 상태를agreements.service_terms/privacy_policy/marketing({agreed, version})로 매핑해서 전송검증
npx tsc -b✅npm run lint✅npx vitest run— 356/356 통과 ✅npm run build✅Closes #279