Skip to content

Support action SHA pinning #92

Description

@rsenden

Enhancement Request

Current action implementation consists of several composite actions that internally reference each other. Due to GitHub limitations, these internal references must be fully qualified action names, including @<version|branch|SHA>. We can't know the commit SHA upfront (chicken-and-egg problem), so only option is to use @<version> or @<branch>, which has been implemented through the update-action-refs.sh script.

Problem with this approach is that this action implementation cannot be used if GitHub is configured to require actions to be pinned by SHA.

As a workaround, we could have every sub-action provide its own full implementation through re-usable scripts, effectively removing all internal action references. Note that we'd also need to use SHA pinning for actions/upload-artifact and any other 3rd-party actions, instead of referencing these by major version, which increases maintenance which could potentially be automated through an auto-update workflow.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions