Skip to content

Fix: Security Vulnerabilities fixes Password Masking, XXE, and Injection Prevention - #1100

Open
jmadhur87 wants to merge 6 commits into
fortify:dev/v3.xfrom
jmadhur87:mjain6/FAAVulnFix2
Open

jmadhur87 wants to merge 6 commits into
fortify:dev/v3.xfrom
jmadhur87:mjain6/FAAVulnFix2

Conversation

@jmadhur87

Copy link
Copy Markdown
Contributor

Summary

Fixed 5 security vulnerabilities across fcli to prevent sensitive data exposure and injection attacks.

Changes

  1. Password Masking (SSCUserCreateLocalCommand, SSCUserUpdateLocalCommand)

    • Passwords are now masked in logs as <REDACTED PASSWORD (CLI_OPTION)>
    • Added interactive mode with echo disabled for secure input
    • Prevents accidental password exposure in command logs
  2. XXE Prevention (SSCActionSpelFunctions)

    • Fixed XML External Entity (XXE) attack vulnerability in FPR file processing
    • Disabled DTD processing and external entity resolution using OWASP standard properties
    • Prevents XXE attacks when parsing untrusted XML files
  3. Terminal Injection Prevention (RecordWriterTable)

    • Added sanitization to strip ANSI escape sequences and control characters
    • Prevents terminal injection attacks through malicious table data
    • Preserves intentional whitespace (tabs, newlines) for layout
  4. SpEL Injection Prevention (MCPToolArgHandlerQuery)

    • Fixed escape order: backslashes first, then single quotes
    • Prevents SpEL string literal breakout attacks
    • Rejects double quotes in query values for additional safety
  5. CLI Injection Prevention (MCPToolArgHandlerQuery)

    • Added field name allowlist validation
    • Prevents injection through unvalidated schema property names
    • Throws error for unknown/unexpected fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant