Skip to content

An unresolvable --range validates the whole history #35

Closed
Closed
An unresolvable --range validates the whole history#35
Labels
bugSomething isn't working

Description

@closer-claudio
closer-claudio
opened on Oct 23, 2026

When git rev-list <range> fails, checkRevList (git/commits.go:53-79) runs git log and returns <oldest available>..HEAD, so a typo in --range silently validates every commit instead of failing.

Decided (Apostasie, 2026-10-22): an unresolvable range is an error. Report it and exit non-zero; the contract tests that pin the fallback change with it.

Activity

  1. closer-claudio
    added
    questionFurther information is requested
    bugSomething isn't working
    and removed
    questionFurther information is requested
    on Oct 23, 2026

  2. closer-claudio commented on Oct 24, 2026

    @closer-claudio
    closer-claudio
    on Oct 24, 2026
    Author

    Fixed by #39, merged as f5a51ca: a --range git cannot resolve is an error naming the range in a repository with its whole history; the oldest-commit fallback stays for a shallow clone.

  3. closer-claudio
    closed this as completedon Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions