CHANGE @W-22462048@ Upgrade PMD from 7.25.0 to 7.26.0 - #486
Conversation
- Updated PMD from 7.25.0 to 7.26.0 in libs.versions.toml and constants.ts - Bumped code-analyzer-pmd-engine package version to 0.44.0-SNAPSHOT - Added new Apex rule InvocableClassNoArgConstructor to RULE_MAPPINGS (Moderate severity; Recommended/ErrorProne/Apex tags) and apex rules goldfile - Java deps (hamcrest, junit-jupiter, slf4j-nop, gson) verified against PMD 7.26.0 core; no changes needed
|
Git2Gus App is installed but the |
aruntyagiTutu
left a comment
There was a problem hiding this comment.
Change itself looks good — minor PMD version bump (7.25.0 → 7.26.0), version kept in sync between libs.versions.toml and constants.ts, new InvocableClassNoArgConstructor rule mapping follows the established severity/tag pattern (matches AvoidInterfaceAsMapKey treatment from #463), and the goldfile entry is updated accordingly. Java/TS builds and tests are reported green.
Holding off on approval per the PR description itself: the PMD 7.25 vs 7.26 scan comparison across the repo corpus is still "⏳ In progress" and the description explicitly says "Do not merge until the comparison results are reviewed and confirmed." Please post those results (or confirm the only diff is the new rule's findings, as expected) before merging — happy to approve once that's attached.
What & Why
Upgrades the PMD engine from 7.25.0 to 7.26.0 as part of the monthly release (@W-22462048@).
Changes
7.26.0ingradle/libs.versions.tomlandsrc/constants.ts(kept in sync).code-analyzer-pmd-enginebumped0.43.0→0.44.0-SNAPSHOT.InvocableClassNoArgConstructor(added in PMD 7.26.0) added toRULE_MAPPINGS:AvoidInterfaceAsMapKey, CHANGE @W-22270236@ - Upgrade PMD from 7.23.0 to 7.24.0 #463).test/test-data/pmdGoldfiles/rules_apexOnly.goldfile.json(description sourced directly from the built engine).Validation
BUILD SUCCESSFUL; clean rebuild ofdist/java-libconfirms onlypmd-*-7.26.0.jarpresent (no stale 7.25.0 jars).PMD Version Comparison (Step 1.2)
⏳ In progress — full scan comparison (
pmd_7_25vspmd_7_26) running across the local repo corpus (435 repos, github.com). Results will be reviewed and attached before merge.