Skip to content

Fix: item notes not populating - #1073

Open
santipalenque wants to merge 1 commit into
masterfrom
fix/notes-not-populating
Open

santipalenque wants to merge 1 commit into
masterfrom
fix/notes-not-populating

Conversation

@santipalenque

@santipalenque santipalenque commented Sep 17, 2026

Copy link
Copy Markdown

https://app.clickup.com/t/9014802374/86bc2ha22

Summary by CodeRabbit

  • Bug Fixes

    • Cart form responses are now preserved as received, including item notes and metadata.
    • Missing user notes no longer overwrite existing note data.
    • Empty cart responses are retained without modification.
  • Tests

    • Added coverage for preserving complete cart form items and response metadata.
    • Added tests for missing notes, existing note retention, and responses containing no items.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 6b30f3b0-fc95-492e-b24d-ba1878a9d380

📥 Commits

Reviewing files that changed from the base of the PR and between 8f6d621 and 367dcba.

📒 Files selected for processing (2)
  • src/reducers/sponsors/__tests__/sponsor-page-cart-list-reducer.test.js
  • src/reducers/sponsors/sponsor-page-cart-list-reducer.js

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

RECEIVE_CART_FORM now stores the response directly in cartForm. Tests verify preservation of item fields, notes, metadata, and itemless responses.

Changes

Cart form preservation

Layer / File(s) Summary
Direct cart-form storage and validation
src/reducers/sponsors/sponsor-page-cart-list-reducer.js, src/reducers/sponsors/__tests__/sponsor-page-cart-list-reducer.test.js
The reducer stores RECEIVE_CART_FORM responses without transforming item notes. Tests verify complete item preservation, missing user_notes handling, and unchanged itemless responses.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 367dc

The cart-form response is stored without lossy item normalization, with coverage for item fields, notes, and itemless responses. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing item notes that were not populating.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@santipalenque santipalenque self-assigned this Sep 17, 2026
@santipalenque
santipalenque force-pushed the fix/notes-not-populating branch from 8f6d621 to 367dcba Compare September 17, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant