Conversation
|
I think this is a change that needs to be done in |
Is there a reason notification-controller hasn't been migrated to |
Yes, a very specific one: |
Got it! Will start with |
04bf238 to
5964f7b
Compare
8fea4da to
1bf9d49
Compare
1ff4d3d to
7131cf1
Compare
6f94d4f to
fb95f55
Compare
fb95f55 to
743d729
Compare
Replace deprecated record.EventRecorder with events.EventRecorder from k8s.io/client-go/tools/events. Update all controllers, event server, and tests to use the new API signature. Signed-off-by: Adrian Fernandez de la Torre <[email protected]>
743d729 to
ec806d9
Compare
Migrates the controller's event recording from the legacy
k8s.io/client-go/tools/recordinterface togithub.com/fluxcd/pkg/runtime/events, which emits structuredevents.k8s.io/v1Events, and moves the event payload API fromfluxcd/pkg/apis/event/v1beta1tofluxcd/pkg/apis/event/v1.kuberecorder.EventRecorderwithevents.Recorderin the Alert, Provider and Receiver reconcilers and in the EventServer.event/v1Eventfsignature, adding an explicitAction(Reconciled, Failed, Validating, Fetching) andRelatedobject argument.event/v1beta1toevent/v1; the dispatched payload now carries theactionfieldmgr.GetEventRecorder/testEnv.GetEventRecorderandevents.NewFakeRecorderin tests instead of the client-go equivalents.relatedObjectfield andevent/v1reference in the event spec.fluxcd/pkgmodules as a setPart of fluxcd/flux2#5761