fix: update Gradle 8.12 + AGP 8.9.1 for JDK 23+ compat#2873
Open
GhagSagar23 wants to merge 2 commits into
Open
fix: update Gradle 8.12 + AGP 8.9.1 for JDK 23+ compat#2873GhagSagar23 wants to merge 2 commits into
GhagSagar23 wants to merge 2 commits into
Conversation
All 22 android sample dirs migrated:
- gradle-wrapper → 8.12-all
- AGP 7.3.0 → 8.9.1
- namespace added where missing (AGP 8.x requirement)
- package= removed from AndroidManifest.xml
- old-style buildscript/apply-plugin → plugins {} DSL where applicable
Fixes flutter#2568
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates all 22 Android sample directories to Gradle 8.12 and AGP 8.9.1, fixing builds on JDK 23+.
Changes per sample category:
gradle-wrapper.properties→ Gradle 8.12-allsettings.gradle, added Kotlin 2.1.0 plugin, removed redundantbuildscriptblock frombuild.gradlebuildscript/apply plugintopluginManagement+plugins {}DSL, addednamespace, removedpackage=from AndroidManifest.xmlapply plugin→plugins {}, added namespace where missing,compileSdk/targetSdk→ 36namespaceWhy Gradle 8.12 + AGP 8.9.1:
Unsupported class file major version 67namespacein build.gradle (removed from AndroidManifest.xml)Test plan
dart tool/ci_script.dart— all packages pass (2 pre-existing failures unrelated to this change:compass_app/serverandcupertino_gallery)dart formatclean)dart analyzeclean)Fixes #2568