Skip to content

[video_player] Upgrade to 2.14.0 - #1095

Open
xiaowei-guan wants to merge 7 commits into
flutter-tizen:mainfrom
xiaowei-guan:video_player_upgrade
Open

[video_player] Upgrade to 2.14.0#1095
xiaowei-guan wants to merge 7 commits into
flutter-tizen:mainfrom
xiaowei-guan:video_player_upgrade

Conversation

@xiaowei-guan

Copy link
Copy Markdown
Contributor

Fix #1094

Main changes

  • Update video_player to 2.14.0.
  • Update video_player_platform_interface to 6.9.0.
  • Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60c69dad9f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/video_player/CHANGELOG.md Outdated
Comment thread packages/video_player/CHANGELOG.md
dependencies:
video_player: ^2.11.1
video_player_tizen: ^2.5.13
video_player: ^2.14.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pub.dev/packages/video_player/changelog#2140
For the new interfaces of video_player (e.g., getVideoTracks(), selectVideoTrack(), and isVideoTrackSupportAvailable()), you need to check for support in code or handle non-support in the README.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the interfaces, the media player doesn't support these interfaces. and the README has included not-supported infomation:
https://github.com/flutter-tizen/plugins/pull/1095/changes#diff-1e0f851343e9d1c0959929911a85dbbc00f95cba7359a17d2ce12b38adc2bfa9L57-L62

The following methods are not currently supported.

- `VideoPlayerPlatform.setAllowBackgroundPlayback()`
- `VideoPlayerPlatform.getAudioTracks()`
- `VideoPlayerPlatform.selectAudioTrack()`
- `VideoPlayerPlatform.isAudioTrackSupportAvailable()`

This plugin has the following limitations.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and add new APIs to the list of unsupported interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants