[video_player_avplay] Add SET_ABR property for HLS fixed bitrate playback - #1090
[video_player_avplay] Add SET_ABR property for HLS fixed bitrate playback#1090gin7773 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd8995799b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| await activeTracks.then((List<Track> result) { | ||
| // ignore: avoid_print | ||
| print('[getActiveTrackInfo()] result: $result'); |
There was a problem hiding this comment.
Remove logging from the public track-info getter
Every application that calls getActiveTrackInfo() now emits the complete track list to stdout, even though callers only requested the returned value. This introduces unsolicited production logging—and potentially repeated, sizable output for polling callers—solely to make the new example display its result; log the result in the example instead and keep the package API side-effect free.
Useful? React with 👍 / 👎.
Main changes:
setAbrproperty to disable adaptive bitrate switching for HLS streams.STARTBITRATE + SET_ABRcombination.