Skip to content

[video_player_avplay] Add SET_ABR property for HLS fixed bitrate playback - #1090

Open
gin7773 wants to merge 2 commits into
flutter-tizen:masterfrom
gin7773:bitrate-issue
Open

[video_player_avplay] Add SET_ABR property for HLS fixed bitrate playback#1090
gin7773 wants to merge 2 commits into
flutter-tizen:masterfrom
gin7773:bitrate-issue

Conversation

@gin7773

@gin7773 gin7773 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Main changes:

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd8995799b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1100 to +1102
await activeTracks.then((List<Track> result) {
// ignore: avoid_print
print('[getActiveTrackInfo()] result: $result');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove logging from the public track-info getter

Every application that calls getActiveTrackInfo() now emits the complete track list to stdout, even though callers only requested the returned value. This introduces unsolicited production logging—and potentially repeated, sizable output for polling callers—solely to make the new example display its result; log the result in the example instead and keep the package API side-effect free.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant