Repository navigation
Fall back to the default branch screenshot baseline for stacked PRs - #118
Merged
Merged
Conversation
PRs that target another feature branch (e.g. #111 onto move-fork-test-assertions) never find a baseline, because Store Baseline only publishes for main and dependency-updates. Pick the base branch when it has a non-PR successful store run, otherwise the default branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot
compareon #111 fails withno matching workflow run found with any artifacts?because #111 targetsmove-fork-test-assertions, notmain. The compare job downloads the baseline filtered on the PR base branch, and Store Baseline only publishes formain/dependency-updates, so the baseline run 41782987785 onmainwas never a candidate.The "Pick the baseline workflow" step now chooses the branch as well: the PR base branch if it has a successful non-PR store run, otherwise the repository default branch (ankiquest store workflow first, then the upstream one, as before). It emits a notice when it falls back. The download step uses
steps.source.outputs.branch.Tests:
node --test .github/tests/*.cjs— added a case that runs the step script against a fakeghcovering base-branch hit, default-branch fallback, upstream-workflow fallback and no baseline at all.Note:
pull_requestworkflows run from the PR's merge ref, so #111 (and other stacked PRs) only pick this up once it reaches their base branch.