Repository navigation
Fix the learning-later deck test near rollover - #115
Merged
Merged
Conversation
Anki shows learning cards up to 20 minutes early as due now. The test puts a card halfway between now and the day cutoff, so in the last 40 minutes before rollover it landed inside that window and the deck read as REVIEW_NOW.
|
Snapshot diff report vs
All 1 changed screenshotsAnkiquestHomeScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnkiquestDecksTest.learning later today keeps deck and parent unfinishedfails in the last 40 minutes before the Anki day rolls over. It puts a learning card halfway between now and the cutoff, and Anki treats learning cards due within 20 minutes (collapseTime) as due now, so the deck readREVIEW_NOWinstead ofLEARNING_LATER. The app is right; the test now setscollapseTimeto 0, as upstream'sReviewCompletionTestandDeckStudyStateTestdo.Seen locally at 03:25 (fails), passes at 03:29 with the change.