Repository navigation
Share conquered cards with what they were, and ask who to tell about a finished deck - #110
Merged
Merged
Conversation
A conquered card's Share first asks whether to show the card: unticked by default, prefilled with its first field (or the label saved before), editable, and saved as the conquest's label on the server only when ticked; sharing without it removes an earlier label. On Android 14 and later the share sheet itself offers AnkiQuest friends next to the other apps; older versions keep asking first.
After a review session that finishes the selected deck, once per deck and Anki day, the app lists the people in the player's groups (none ticked) and sends the completion to those picked through the server. Decks that already announce themselves to chosen people are left alone. A switch in Friends & sharing turns the question off, as does Don't ask again.
|
Snapshot diff report vs
All 1 changed screenshotsPreferencesScreenshotTest
|
# Conflicts: # AnkiDroid/src/test/java/com/ichi2/anki/analytics/PreferencesAnalyticsTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
Fixes #102
Needs float3/ankiquest#138 for the first-person wording, the card label on shared cards and the finished-deck endpoint. Against an older server a conquered card shares as before, and telling friends about a deck says the server can't do it yet.
Conquered cards (#103)
POST /api/conquests/{user}/{at}/label); sharing unticked removes an earlier label. The card's text never leaves the phone otherwise.EXTRA_CHOOSER_CUSTOM_ACTIONS, an immutable PendingIntent back to the non-exported share activity). Before Android 14 there is no way to add an entry, so the friends / other apps question stays and "Somewhere else…" opens the share sheet. This applies to every win, not only conquered cards.Finished decks (#102)
recipientsofGET /api/decks), with nobody ticked, and sends the completion to the people picked (POST /api/decks/{user}/share). It shows after the session summary, or on its own when the summary is off or AnkiQuest navigation isn't used.Strings in en/de/es/fr/pt. Tests:
AnkiquestShareTest(win key, label read/write/remove, finished deck request, card text cleaning, chosen label, share sheet entry on SDK 36 and none on 33, topic on the Share button), newAnkiquestDeckShareTest(who is asked, decks already shared, once a day, the switch),AnkiquestNotifierTest,AnkiquestSettingsMenuTest,PreferencesAnalyticsTest. The dialogs themselves and the Android 14 sheet entry haven't been tried on a device.