Skip to content

fix: dual-support OCP 4.20 and 4.22 Cypress selectors - #39

Open
talhil-rh wants to merge 1 commit into
flightctl:mainfrom
talhil-rh:fix/ocp-422-dual-selectors
Open

fix: dual-support OCP 4.20 and 4.22 Cypress selectors#39
talhil-rh wants to merge 1 commit into
flightctl:mainfrom
talhil-rh:fix/ocp-422-dual-selectors

Conversation

@talhil-rh

@talhil-rh talhil-rh commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Cypress failures on OCP 4.22 (job-runner-talh/371, nested flightctl-cypress-test #148) came from the flightctl-ui#803 details-page redesign.
  • Selectors now match both OCP 4.20 and 4.22 layouts (both already use PatternFly v6):
    • Device details Fleet name (4.20 .fctl-device-details-tab__label) vs Fleet (4.22 DescriptionList term)
    • Add label inside LabelGroup (4.20) vs sibling EditableLabelControl (4.22)
    • Expandable Security overview card on device/fleet pages
  • deviceApps #fctl-applications-table also accepts #device-applications-card table / table[aria-label="Applications"]. A 10-minute wait with no table still means the VM apps never appeared in device status (product/infra), not a missing class name.

Test plan

  • Re-run Cypress on OCP 4.22 (ocp-edge126.lab.eng.tlv2.redhat.com / job-runner-talh) and confirm:
    • Device Management — fleet label detach/reattach
    • Fleet Management — create + delete fleet
    • Vulnerability Reporting — create fleet with device selector, attach device
  • Confirm the same specs still pass on OCP 4.20 (legacy .fctl-device-details-tab__label + "Fleet name")
  • Device applications (KVM) — table is found when apps exist; remaining 600s timeout is infra if status never reports apps

flightctl-ui PR #803 renamed device details "Fleet name" to "Fleet",
moved Add label outside LabelGroup, and made the security card expandable.
Keep the OCP 4.20 layout selectors alongside the new 4.22 ones.

Assisted-by: Claude
@talhil-rh
talhil-rh force-pushed the fix/ocp-422-dual-selectors branch from f08a73b to d77b9da Compare September 10, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant