feat: support json v2 ephemeral cards - #4
Draft
alick-liming wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CardV2 json.RawMessage, while preservingCard *MessageContentCardfor V1 callers.cardobject, reject conflicting V1/V2 inputs, and omit an unset card. Cover all four cases with tests.Rangefield from the whole-file download test. Existing assertions remain intact.Validation
go test . -run '^Test_Request$' -count=1— passed; reproduced the nil method-option panic before the fixture fix.go test . -run '^TestSendEphemeralMessageReq' -count=1— passed.go test ./... -run '^$' -count=1— all test packages compile.go vet ./...— passed.go build ./...— passed.go mod verify— passed.git diff --check— passed.go test ./... -count=1 -timeout=60s— the root, card, internal, and larkext packages passed. The test package reached the explicit 60-second limit inTest_CoreHR_Sample_Failed/response_is_failedwhile requesting a tenant token from Feishu. This is not a full-suite pass; external integration validation remains outstanding.Scope / Notes
CardV2when importing regenerated SDK code. This is a maintenance note, not a demonstrated failure in the current build.