Skip to content

[shell-operator] fix: restore ARM images and preserve hook logs - #956

Merged
ldmonster merged 9 commits into
mainfrom
fix/arm-container-images
Oct 29, 2026
Merged

ldmonster merged 9 commits into
mainfrom
fix/arm-container-images

Conversation

@Glitchy-Sheep

@Glitchy-Sheep Glitchy-Sheep commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Fix ARM images containing amd64 binaries. Closes #920.

Changes

  • Use official multiarch Go 1.26.4 / Alpine 3.23 bases, pinned by index digest; install jq via apk.
  • Check Alpine and five binaries against the target architecture; fail before publication on mismatch.
  • Run full amd64, ARM64 and ARM/v7 builds only when FROM instructions change or on manual request.
  • Align three indirect Go module requirements that blocked compilation.
  • Fix existing CI failures: use Python 3.12 for codespell and preserve incomplete hook log records between writes.
  • Add regression tests for fragmented logs, EOF, malformed JSON and truncation.

Validation

@Glitchy-Sheep Glitchy-Sheep added the bug Something isn't working label Oct 28, 2026
@Glitchy-Sheep Glitchy-Sheep self-assigned this Oct 28, 2026
@Glitchy-Sheep
Glitchy-Sheep marked this pull request as ready for review October 28, 2026 11:10
@Glitchy-Sheep Glitchy-Sheep changed the title [shell-operator] fix: restore ARM container images [shell-operator] fix: restore ARM images and preserve hook logs Oct 28, 2026
@Glitchy-Sheep
Glitchy-Sheep marked this pull request as draft October 28, 2026 15:19
@Glitchy-Sheep
Glitchy-Sheep marked this pull request as ready for review October 29, 2026 07:29
@ldmonster
ldmonster merged commit ccd0f3e into main Oct 29, 2026
11 checks passed
@ldmonster
ldmonster deleted the fix/arm-container-images branch October 29, 2026 12:57
@redbaron

Copy link
Copy Markdown

@ldmonster , @Glitchy-Sheep , thanks for fixing it and tagging a new release. Do you plan to publish new image? Asking because previous release 1.21.3 didn't have image in https://github.com/flant/shell-operator/pkgs/container/shell-operator

@Glitchy-Sheep

Copy link
Copy Markdown
Contributor Author

publish new image

@redbaron yes, ghcr.io/flant/shell-operator:v1.21.4 is available in GHCR.

The backport images v1.20.7 and v1.19.6 are also should be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linux/arm64 image contains x86_64 binaries

3 participants