test(idea-posterior): budget browser-probe timeouts for slow CI Chrome starts - #50
Merged
Merged
Conversation
…e starts Since ~2026-08-07 the ubuntu-latest runner image ships a Chrome whose headless cold start can stall past 15 s on D-Bus connect waits (the libdbus default method-call timeout is 25 s). The reader-surface probe then hit the 15 s main communicate() timeout, SIGTERMed the browser group, and the 5 s cleanup communicate() raised the uncaught TimeoutExpired that failed python-contracts-test twice on independent runner instances (PR #49 run 31140161012). Main's last green run was 2026-08-03, so the regression tracks the runner image, not code. Raise both waits to 30 s. Wall-clock budgets only guard against a wedged browser: the in-page work is bounded by --virtual-time-budget and communicate() returns on process exit, so the content assertions are unchanged and a healthy run is not slowed.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
skills/idea-posterior/tests/test_reader_surface_interactions.py::test_interactive_visible_probabilities_share_static_precisionfails on GitHub Actions (jobpython-contracts-test, step "Python tests (interactive argument-graph reader surface)") since ~2026-08-07 withsubprocess.TimeoutExpired ... timed out after 5 secondswhile launchinggoogle-chrome --headless=new ... --virtual-time-budget=3000 --dump-dom, preceded by a D-Bus connect error on stderr. PR #49 run 31140161012 hit it twice (fresh run + rerun, different runner instances, identical failure); the same test on the same code passes locally. Main's last green CI was 2026-08-03, so the regression tracks a runner-image/Chrome update, not a code change.Diagnosis
The uncaught exception saying "after 5 seconds" can only originate from the post-SIGTERM cleanup
communicate(timeout=5): the maincommunicate(timeout=15)'s ownTimeoutExpiredis always caught by the surroundingexcept. So on the updated runner Chrome first stalled past the 15 s main timeout (consistent with a startup D-Bus connect wait; the libdbus default method-call timeout is 25 s), was SIGTERMed, and then also failed to exit within 5 s. Raising only the 5 s cleanup value would therefore not make CI green — Chrome would still be killed at 15 s mid-startup,--dump-domwould never emit, and the test would fail onassert stdout, stderrinstead.Fix
Raise both waits to 30 s (main
communicate15 → 30, post-SIGTERM cleanup 5 → 30). This does not weaken what the test asserts: the in-page work is bounded by Chrome's--virtual-time-budget=3000(virtual ms),communicate()returns as soon as the process exits, and every DOM-content assertion (probability precision, control inventory, reader-surface contract) is untouched. The wall-clock values are purely a guard against a wedged browser.Repo-wide, this file is the only place that launches a browser subprocess with fixed timeouts (
grep -rn "communicate(timeout="— the two review-swarm hits are parameterized launcher code, not browser tests).Verification
python3 -m pytest skills/idea-posterior/tests/test_reader_surface_interactions.py -q→ 2 passed locallynode scripts/check-idea-posterior-reader-surface-anti-drift.mjs→ passes (the lock pins interaction/contract anchors, not timeout values, and forbidspytest.skiphere — so "skip on CI" was never a legal alternative)git diff --checkcleanDBUS_SESSION_BUS_ADDRESSat an unreachable address so connects fail fast), not a larger number.skills/review-swarm/scripts/bin/run_multi_task.py:834already has the stronger pattern if a follow-up wants it.Note for PR #49
PR #49's
python-contracts-testfailure is this same environment issue, not a defect in that branch. It should clear once this lands on main and #49's CI runs against an updated merge base (branch update / rebase / new push — a plain re-run of the old run reuses the old merge commit).