Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps react-native-webgpu from 0.10.1 to 0.19.2 in both camera packages and
fishjam-chat, and stops requestingrnwebgpu/native-texture.REQUIRED_FEATURESinreact-native-custom-video-sourcenow lists only the platform feature (dawn-multi-planar-formatson iOS,opaque-ycbcr-android-for-external-textureon Android);react-native-vision-camera-sourcebuilds on it.fishjam-chatstill needs@fishjam-cloud/video-effectsbumped to a release with fishjam-cloud/video-effects#10, since 0.1.3 still requests the removed feature. Draft until that's out.Motivation and Context
react-native-webgpu 0.12 removed the
rnwebgpu/native-texturefeature (wcandillon/react-native-webgpu#498) andrequestDevicethrows when it's requested, so on 0.12+useCameraWebGpuDevicecan't create the device andassertWebGpuDeviceSupportsCameraImportrejects any device the app passes in. Apps on a current react-native-webgpu can't use the camera sources at all.The peer range stays
>=0.5.15, since 0.5.15–0.11 turn the native-texture features on by themselves when the adapter has them. The only difference there is that an adapter without them fails on the first frame instead of at device creation.The 0.19.2 bump brings Dawn 157, readable native errors on Android, and
destroy()on shared texture memory and fences (wcandillon/react-native-webgpu#516) that we need to stop per-frame fence memory growth on Android. No API changes were needed.Tested:
tscpasses for both camera packages, and background blur works infishjam-chaton an iPhone 17 Pro Max (iOS 27.2) with fishjam-cloud/video-effects#10 built locally.useVisionCameraWebGpuSourceis only typechecked, the example doesn't use it. I haven't run it on Android.Documentation impact
Types of changes
not work as expected)