Repository navigation
chore(cf-v2): shorten GitHub check names - #91
Merged
Merged
Conversation
Only job `name:` fields (and the comments, docs and contract tests that hard-code them) change; needs/if/outputs/permissions/concurrency/secrets/environments are untouched. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shortens the GitHub check names produced by the shared v2 workflows. Only job
name:fields change (plus the comments/docs/tests that hard-code them).needs,if, outputs, permissions, concurrency, secrets and environments are untouched.Displayed check =
<caller job> / <reusable job name…>; consumers will name their caller jobCD(separate change).Delivery planPlan_cf-worker-v2.yml:490Database MigrationMigrate_cf-worker-v2.yml:536Delivery (production|native-branch|native-dev|persistent-dev)production/native-branch/native-dev/persistent-dev_cf-worker-v2.yml:606,633,652,671Deploy/Smoke Tests/Revert on Verify FailureCD / native-dev / Deploy_cf-worker-delivery.ymlConfig guardGuard_cf-worker-v2.yml:722Preview lifecycle(caller) /Preview lifecycle(inner)lifecycle/ledger_cf-worker-v2.yml:736,_cf-worker-lifecycle.yml:38Persistent Dev (Hybrid)(caller) / same (inner)persistent-dev/manual_cf-worker-v2.yml:750,_cf-worker-persistent-dev.yml:61CI / Lint … Validation Gate,ReleaseDeliberate deviations from the brief: (1) the inner persistent-dev job is
manual, not a repeat ofpersistent-dev; (2) the manual-dispatch handlerpersistent-devnow shares its name with Delivery kindpersistent-dev. They never run on the same event (push vsworkflow_dispatch), and a contract test pins that this is the only shared name._cf-worker-template.yml(v1) is untouched.No behavior / runtime change
name:lines (9 in v2, 1 lifecycle, 1 persistent-dev) plus comments; no other YAML key changed.github.job,GITHUB_JOB,check-runs,workflow_job, job-name matching acrossactions/,scripts/,packages/,.github/): none found. Ledger/rollback/status logic keys on job ids, outputs and SHA/run ids.Hard-coded names updated
scripts/cf-preview/test-workflow-contract.py(name assertions + new "check names" pins),scripts/cf-preview/test-jobs.py(docstring), comments in_cf-worker-v2.yml,_cf-worker-delivery.yml,actions/cf-deploy/action.yml,actions/cf-preview/delivery.mjs, and the check-name tables/diagrams indocs/cf-worker-v2-{refactor,rollout,unified-delivery}.md(consumerPipeline→CD). Historical run-evidence rows andopenspec/changes/**records were left as-is.Verification
scripts/cf-preview/test.sh full: PASSED (contract incl. 6 new name checks, node unit+cli, deploy, migrate, smoke, parse-env, probe, gh, testsh, gc unit, delivery chain groups).cf-worker-v2-ciworkflow runs them on this PR.Compatibility
Consumers call the floating
@v2(at 8ff47d3, not moved), so merging changes nothing for them until the maintainer moves the tag; then all consumers' check names change at once. Required-check status of the consumer repositories was verified separately (details kept out of this public PR). A read-only look at one consumer's guardrail test shows it pinsuses: …@v2, inputs, secrets and the caller job key, not reusable job/check names.Rollback
Revert this PR, or simply keep the
v2tag where it is.🤖 Generated with Claude Code