Skip to content

chore(cf-v2): shorten GitHub check names - #91

Merged
ClaudiaFang merged 1 commit into
mainfrom
chore/shorten-v2-job-names
Nov 4, 2026
Merged

ClaudiaFang merged 1 commit into
mainfrom
chore/shorten-v2-job-names

Conversation

@ClaudiaFang

@ClaudiaFang ClaudiaFang commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

What

Shortens the GitHub check names produced by the shared v2 workflows. Only job name: fields change (plus the comments/docs/tests that hard-code them). needs, if, outputs, permissions, concurrency, secrets and environments are untouched.

Displayed check = <caller job> / <reusable job name…>; consumers will name their caller job CD (separate change).

Before After Where
Delivery plan Plan _cf-worker-v2.yml:490
Database Migration Migrate _cf-worker-v2.yml:536
Delivery (production|native-branch|native-dev|persistent-dev) production / native-branch / native-dev / persistent-dev _cf-worker-v2.yml:606,633,652,671
inner Deploy / Smoke Tests / Revert on Verify Failure unchanged, e.g. CD / native-dev / Deploy _cf-worker-delivery.yml
Config guard Guard _cf-worker-v2.yml:722
Preview lifecycle (caller) / Preview lifecycle (inner) lifecycle / ledger _cf-worker-v2.yml:736, _cf-worker-lifecycle.yml:38
Persistent Dev (Hybrid) (caller) / same (inner) persistent-dev / manual _cf-worker-v2.yml:750, _cf-worker-persistent-dev.yml:61
CI / Lint … Validation Gate, Release unchanged –

Deliberate deviations from the brief: (1) the inner persistent-dev job is manual, not a repeat of persistent-dev; (2) the manual-dispatch handler persistent-dev now shares its name with Delivery kind persistent-dev. They never run on the same event (push vs workflow_dispatch), and a contract test pins that this is the only shared name. _cf-worker-template.yml (v1) is untouched.

No behavior / runtime change

  • Workflow diff is name: lines (9 in v2, 1 lifecycle, 1 persistent-dev) plus comments; no other YAML key changed.
  • Runtime name-dependence search (github.job, GITHUB_JOB, check-runs, workflow_job, job-name matching across actions/, scripts/, packages/, .github/): none found. Ledger/rollback/status logic keys on job ids, outputs and SHA/run ids.

Hard-coded names updated

scripts/cf-preview/test-workflow-contract.py (name assertions + new "check names" pins), scripts/cf-preview/test-jobs.py (docstring), comments in _cf-worker-v2.yml, _cf-worker-delivery.yml, actions/cf-deploy/action.yml, actions/cf-preview/delivery.mjs, and the check-name tables/diagrams in docs/cf-worker-v2-{refactor,rollout,unified-delivery}.md (consumer Pipeline → CD). Historical run-evidence rows and openspec/changes/** records were left as-is.

Verification

  • scripts/cf-preview/test.sh full: PASSED (contract incl. 6 new name checks, node unit+cli, deploy, migrate, smoke, parse-env, probe, gh, testsh, gc unit, delivery chain groups).
  • actionlint and shellcheck were not run locally (not installed; a local download-and-run was blocked). The repo's cf-worker-v2-ci workflow runs them on this PR.

Compatibility

Consumers call the floating @v2 (at 8ff47d3, not moved), so merging changes nothing for them until the maintainer moves the tag; then all consumers' check names change at once. Required-check status of the consumer repositories was verified separately (details kept out of this public PR). A read-only look at one consumer's guardrail test shows it pins uses: …@v2, inputs, secrets and the caller job key, not reusable job/check names.

Rollback

Revert this PR, or simply keep the v2 tag where it is.

🤖 Generated with Claude Code

Only job `name:` fields (and the comments, docs and contract tests that hard-code them) change; needs/if/outputs/permissions/concurrency/secrets/environments are untouched.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@ClaudiaFang
ClaudiaFang merged commit 54af6f7 into main Nov 4, 2026
1 check passed
@ClaudiaFang
ClaudiaFang deleted the chore/shorten-v2-job-names branch November 4, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant