Add ScanPeers() to iterate peers with zero allocations - #44
Merged
orsinium merged 5 commits intoSep 5, 2026
Merged
Conversation
applejag
force-pushed
the
feature/zero-alloc-peer-scanner
branch
from
September 4, 2026 21:01
3c7aa9d to
09e1c70
Compare
orsinium
reviewed
Sep 5, 2026
orsinium
reviewed
Sep 5, 2026
orsinium
reviewed
Sep 5, 2026
Co-authored-by: Gram <[email protected]>
Member
|
Perfect, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
firefly.Peers.Sliceallocates a slice, and TinyGo doesn't inlinefirefly.Peers.Itercorrectly and so it also allocates.I've been using a Scanner hack in some of my projects to avoid the allocations. Maybe it could be added to the SDK?
I ran
go doc -httpto see how this renders, and here's a sample: