fix(sheet): omit hidden rows and columns in OOXML xlsx

[HaoChiBao]

Related to #9 (row/column half). Does not close #9; coexist with #39 (sheet-level half).

Summary

• Stream <row hidden> / <col hidden> from OOXML worksheet parts (calamine does not expose them)
• Omit those axes when building Document/Markdown tables; adjust merges to visible cells
• Scope: xlsx/xlsm OOXML only. Binary xls/xlsb and ODS unchanged

Out of scope

• Hidden / veryHidden worksheets (PR fix(sheet): skip hidden and very-hidden worksheets #39)
• Collapsed outline groups and zero width/height axes
• Include-hidden option (no sheet options pattern in the library today)

Test plan

• Synthetic xlsx fixture: visible cell kept; hidden row/col text absent from markdown and document
• Existing merge fixture tests still pass
• cargo fmt, clippy -D warnings, cargo test --locked --lib

---

Summary by cubic

Omits hidden rows and columns in OOXML .xlsx/.xlsm so hidden content no longer appears in generated tables and Markdown. Previously we rendered hidden axes because calamine does not expose <row hidden>/<col hidden>; now we stream visibility from worksheet parts and adjust merges.

• Scope: OOXML only; .xls/.xlsb and ODS behave as before.
• Merges: drop a merge if its origin is hidden; otherwise compute span from visible rows/cols so covered cells align with what remains visible.
• Implementation: new visibility module loads hidden axes per sheet by reading xl/workbook.xml, xl/_rels/workbook.xml.rels, and each worksheet XML with resource caps; if a part can’t be read within limits, we warn and leave that sheet unfiltered.

^{Written for commit b6fe9a5. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/formats/sheet/mod.rs">

<violation number="1" location="src/formats/sheet/mod.rs:88">
P2: When a merged range has a hidden top-left row or column, this `continue` bypasses registration of its visible covered cells. Any raw values in those cells then leak into the document and Markdown; blank or suppress the visible covered positions while dropping the hidden origin.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[cubic-dev-ai]

P2: When a merged range has a hidden top-left row or column, this continue bypasses registration of its visible covered cells. Any raw values in those cells then leak into the document and Markdown; blank or suppress the visible covered positions while dropping the hidden origin.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/formats/sheet/mod.rs, line 88:

<comment>When a merged range has a hidden top-left row or column, this `continue` bypasses registration of its visible covered cells. Any raw values in those cells then leak into the document and Markdown; blank or suppress the visible covered positions while dropping the hidden origin.</comment>

<file context>
@@ -65,22 +76,51 @@ pub fn parse(bytes: &[u8]) -> Result<Document, ConvertError> {
+            }
+            // Value lives at the merge origin; if that axis is hidden, drop
+            // the merge so remaining visible covered cells stay empty.
+            if axis_row_hidden(hidden, start.0 + r0 as u32)
+                || axis_col_hidden(hidden, start.1 + c0 as u32)
+            {
</file context>

Suggested change

	if axis_row_hidden(hidden, start.0 + r0 as u32)
	|| axis_col_hidden(hidden, start.1 + c0 as u32)
	{
	continue;
	}
	if axis_row_hidden(hidden, start.0 + r0 as u32)
	|| axis_col_hidden(hidden, start.1 + c0 as u32)
	{
	for &r in &visible_rows {
	for &c in &visible_cols {
	covered.insert((r, c));
	}
	}
	continue;
	}