fix(xlsx): retain embedded worksheet images - #151
Open
Fanfulla wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Fanfulla
force-pushed
the
fix/xlsx-embedded-assets
branch
from
August 31, 2026 14:35
7d3db22 to
11c8c14
Compare
Author
|
Fixed in 11c8c14. I reran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the XLSX side of #139.
The parser now follows the worksheet -> drawing -> image relationship chain and stores embedded image bytes in
Document.assets, using the existingAssetSinkbehavior for byte limits and deduplication. Each asset keeps its media type and original package path.I kept Markdown output out of scope. This change only makes the shared document model complete for XLSX files. Positional Markdown references are still tracked in #63.
Tests:
cargo fmt --all --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --lockedFixes #139