Repository navigation
Use split_array_ref #3347
Description
Use <[T; N]>::split_array_ref to improve src/cpuid/src/intel/mod.rs IntelCpuid::default_brand_string.
Blocked on rust-lang/rust#90091
split_array_ref #3347Use <[T; N]>::split_array_ref to improve src/cpuid/src/intel/mod.rs IntelCpuid::default_brand_string.
Blocked on rust-lang/rust#90091
Activity
0xkelvin commentedon Mar 16, 2023
can i take this @JonathanWoollett-Light
JonathanWoollett-Light commentedon Mar 16, 2023
@0xkelvin This issue cannot be closed or worked on until rust-lang/rust#90091 is closed and
<[T; N]>::split_array_refis stabilized.0xkelvin commentedon Mar 16, 2023
i see
roypat commentedon Nov 13, 2024
Hey Jonathan, I've had a look at the
default_brand_stringfunction, and I honestly don't see where we could usesplit_array_refin it, even if it were stabilized (and actually it seems likesplit_array_refgot removed altogether in rust-lang/rust#117561).So I'm closing this for now. Please feel free to reopen if you still think there's a refactor possible in
default_brand_string