Skip to content

Fix/phase 2 remediation - #30

Merged
tomer-shoham merged 88 commits into
mainfrom
fix/phase-2-remediation
Nov 10, 2026
Merged

tomer-shoham merged 88 commits into
mainfrom
fix/phase-2-remediation

Conversation

@tomer-shoham

Copy link
Copy Markdown
Contributor

No description provided.

Fixes 205. deriveFundingExternalId hashed only vault:network:bond:bondIndex:
It now includes the persisted funding generation to ensure uniqueness across retries.
[FIREHOG-BYPASS] false positive
@semgrep-code-fireblocks

Copy link
Copy Markdown

Semgrep found 798 block-public-registry-refs-in-package-lock findings:

🟠 High severity issue identified in your code:

package-lock.json contains a reference to a public package registry or CDN (https://registry.npmjs.org/commander/-/commander-9.5.0.tgz). Dependencies must be resolved through the approved internal JFrog/Artifactory registry. Update your .npmrc to point at the approved registry, delete node_modules and package-lock.json, then re-run npm install and commit the regenerated lockfile.

tomer-shoham and others added 2 commits November 2, 2026 16:13
Regenerated because no lockfile is committed. Installed with npm ci and tested before this commit.
@socket-security

socket-security Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Priority Alert  (click "▶" to expand/collapse) Action
Medium priority
Critical CVE: Handlebars: JavaScript Injection via AST Type Confusion in compile (bypass of CVE-2026-33937)

CVE: GHSA-8r5x-fm3f-whwj Handlebars: JavaScript Injection via AST Type Confusion in compile (bypass of CVE-2026-33937) (CRITICAL)

Affected versions: >= 4.0.0 < 4.7.10

Patched version: 4.7.10

From: package-lock.json → npm/[email protected] → npm/[email protected]

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn

View full report

@semgrep-code-fireblocks

Copy link
Copy Markdown

Semgrep found 66 block-public-registry-refs-in-package-lock findings:

🟠 High severity issue identified in your code:

package-lock.json contains a reference to a public package registry or CDN (https://registry.npmjs.org/update-browserslist-db/-/update-browserslist-db-1.3.3.tgz). Dependencies must be resolved through the approved internal JFrog/Artifactory registry. Update your .npmrc to point at the approved registry, delete node_modules and package-lock.json, then re-run npm install and commit the regenerated lockfile.

@semgrep-code-fireblocks

Copy link
Copy Markdown

Semgrep found 7 ssc-ecb9fa33-f155-478d-a626-7f0e5367c4a4 findings:

  • src/server.ts
  • src/tests/resumeBondRegistration.controller.test.ts
  • src/tests/repointBondFunding.route.test.ts
  • src/tests/noBodyRoutes.test.ts
  • src/tests/listBondLockRecordsRoute.test.ts
  • src/tests/auth.test.ts
  • src/tests/abandonBroadcastFunding.route.test.ts

🟠 High severity issue identified in your code:

Risk: Affected versions of body-parser are vulnerable to Uncaught Exception. When a request carries a Content-Encoding header (gzip, deflate, br), body-parser pipes the body into a zlib decompression stream that remains piped without an error listener after the body is read. An unauthenticated attacker can send a valid compressed frame followed by trailing bytes, causing the decoder to emit an uncaught error that crashes the Node.js process (denial of service). All parsers (json, raw, text, urlencoded, and the Express re-exports) are affected unless the inflate: false option is set.

Fix: Upgrade this library to at least version 2.4.0 at stacks-fireblocks-sdk/package-lock.json:3907.

Reference(s): https://euvd.enisa.europa.eu/vulnerability/EUVD-2026-108189, GHSA-27r3-jxmh-p828, CVE-2026-111181

@tomer-shoham
tomer-shoham merged commit e926b2c into main Nov 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants