fix: improve deploy error message when default app engine service acc…#10835
Open
IzaakGough wants to merge 4 commits into
Open
fix: improve deploy error message when default app engine service acc…#10835IzaakGough wants to merge 4 commits into
IzaakGough wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fast-fail check during the deployment of 1st generation Cloud Functions to ensure that the default App Engine service account exists and is enabled when needed, preventing generic internal errors later in the deployment pipeline. The changes include the implementation of checkDefaultServiceAccountEnabled in checkIam.ts, its integration into the deployment flow in deploy.ts, and comprehensive unit tests in checkIam.spec.ts. The review feedback suggests a minor optimization in checkIam.ts to remove redundant array spreading when calling flattenArray.
IzaakGough
marked this pull request as ready for review
July 21, 2026 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4524