Update Android test framework polling#1888
Open
a-maurice wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces ALooper_pollAll with ALooper_pollOnce in the Android event processing loop. The reviewer points out that the loop condition should also account for ALOOPER_POLL_CALLBACK to ensure all pending events are fully drained and not left unprocessed in the queue.
a-maurice
added
the
tests-requested: quick
github-actions
Bot
added
tests: in-progress
Integration test with FLAKINESS (succeeded after retry)Requested by @a-maurice on commit a8ba9e6
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
Bot
added
the
tests: succeeded
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ALooper_pollAll has been deprecated and removed in newer NDK versions. Switch to use ALooper_pollOnce instead.
Testing
Building locally.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.