Skip to content

chore: replace ioutil.ReadFile with os.ReadFile - #718

Merged
jonathanedey merged 35 commits into
firebase:devfrom
oswaldom-code:chore/replace-ioutil-readfile
Aug 21, 2026
Merged

chore: replace ioutil.ReadFile with os.ReadFile#718
jonathanedey merged 35 commits into
firebase:devfrom
oswaldom-code:chore/replace-ioutil-readfile

Conversation

@oswaldom-code

@oswaldom-code oswaldom-code commented Sep 21, 2025

Copy link
Copy Markdown

Go deprecated the ioutil package in version 1.16. This PR replaces ioutil with "os" and "io" across the codebase. No functional changes were introduced.

  • Replaced imports of "io/ioutil" with "os" and "io"
  • Updated all calls to ioutil.ReadFile -> os.ReadFile
  • Updated all calls to ioutil.ReadAll --> io.ReadAll

All unit tests pass with go test -test.short ./....

  This commit removes the dependency on ioutil by replacing all usages of ioutil.ReadAll
  with the recommended io.ReadAll function.

  No functional changes are introduced
@wiz-9635d3485b

wiz-9635d3485b Bot commented Aug 10, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 1 Medium
Software Management Finding Software Management Findings -
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

@jonathanedey jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but 2 spots still need updating, Thanks!

Comment thread messaging/messaging_batch_test.go Outdated
Comment thread messaging/messaging_batch_test.go Outdated
@oswaldom-code
oswaldom-code force-pushed the chore/replace-ioutil-readfile branch 3 times, most recently from b0d37cf to d51f2cd Compare August 21, 2026 10:34

@jonathanedey jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you @oswaldom-code for the contribution!

@jonathanedey jonathanedey changed the title [chore]: replace ioutil.ReadFile with os.ReadFile chore: replace ioutil.ReadFile with os.ReadFile Aug 21, 2026
@jonathanedey
jonathanedey merged commit f4b1a68 into firebase:dev Aug 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants